Skip to content

Commit 72a10c2

Browse files
committed
chore: add dev tools to mise.toml, remove redundant CI installs
- Add temporal 1.7.2, cargo-component 0.21.1, cargo-msrv 0.19.3 to mise.toml (versions pinned per 2-week minimum age policy) - Remove redundant 'rustup component add rustfmt clippy' (2 places) Already declared in rust-toolchain.toml components - Remove 'cargo install cargo-msrv' (now via mise) - Remove 'cargo install --locked cargo-component' (now via mise) - Remove 'temporalio/setup-temporal' action (now via mise) - Add missing 'cache-bin: false' to wasm-workflow-tests rust-cache - Remove dead 'submodules: recursive' (3 places, no submodules exist) Closes #1383
1 parent 8e21d5b commit 72a10c2

3 files changed

Lines changed: 4 additions & 13 deletions

File tree

‎.github/workflows/heavy.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ jobs:
2121
runs-on: ubuntu-latest-16-cores
2222
steps:
2323
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
24-
with:
25-
submodules: recursive
2624
- uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
2725
- name: Run mise install
2826
uses: jdx/mise-action@e6a8b3978addb5a52f2b4cd9d91eafa7f0ab959d # v4.2.0

‎.github/workflows/per-pr.yml‎

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ jobs:
2121
runs-on: ubuntu-latest
2222
steps:
2323
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
24-
with:
25-
submodules: recursive
2624
- uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
2725
- name: Run mise install
2826
uses: jdx/mise-action@e6a8b3978addb5a52f2b4cd9d91eafa7f0ab959d # v4.2.0
@@ -31,7 +29,6 @@ jobs:
3129
- name: Set PROTOC
3230
shell: bash
3331
run: printf 'PROTOC=%s\n' "$(mise which protoc)" >> "$GITHUB_ENV"
34-
- run: rustup component add rustfmt clippy
3532
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
3633
with:
3734
cache-bin: false
@@ -116,8 +113,6 @@ jobs:
116113
runs-on: ubuntu-latest
117114
steps:
118115
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
119-
with:
120-
submodules: recursive
121116
- uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
122117
- name: Run mise install
123118
uses: jdx/mise-action@e6a8b3978addb5a52f2b4cd9d91eafa7f0ab959d # v4.2.0
@@ -126,13 +121,11 @@ jobs:
126121
- name: Set PROTOC
127122
shell: bash
128123
run: printf 'PROTOC=%s\n' "$(mise which protoc)" >> "$GITHUB_ENV"
129-
- run: rustup component add rustfmt clippy
130124
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
131125
with:
132126
cache-bin: false
133127
save-if: ${{ github.ref == 'refs/heads/main' }}
134128
key: msrv
135-
- run: cargo install cargo-msrv
136129
- run: cargo msrv verify
137130
working-directory: ./crates/sdk-core
138131

@@ -217,10 +210,9 @@ jobs:
217210
run: printf 'PROTOC=%s\n' "$(mise which protoc)" >> "$GITHUB_ENV"
218211
- uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
219212
with:
213+
cache-bin: false
220214
save-if: ${{ github.ref == 'refs/heads/main' }}
221215
key: wasm-workflow-tests
222-
- name: Install cargo-component
223-
run: cargo install --locked cargo-component
224216
- run: cargo integ-test -t wasm_workflow_tests -- --test-threads 1
225217

226218
cloud-tests:
@@ -300,8 +292,6 @@ jobs:
300292
save-if: ${{ github.ref == 'refs/heads/main' }}
301293
- name: Build examples
302294
run: cargo build --examples -p temporalio-sdk --features examples
303-
- name: Install Temporal CLI
304-
uses: temporalio/setup-temporal@1059a504f87e7fa2f385e3fa40d1aa7e62f1c6ca # v0
305295
- name: Start Temporal dev server
306296
run: |
307297
temporal server start-dev --headless &

‎mise.toml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,5 @@
11
[tools]
22
protoc = "23.4"
3+
temporal = "1.7.2"
4+
"cargo:cargo-component" = "0.21.1"
5+
"cargo:cargo-msrv" = "0.19.3"

0 commit comments

Comments
 (0)