chore: extract composite action for CI setup, selective mise installs#1387
Open
brucearctor wants to merge 2 commits into
Open
chore: extract composite action for CI setup, selective mise installs#1387brucearctor wants to merge 2 commits into
brucearctor wants to merge 2 commits into
Conversation
brucearctor
force-pushed
the
feat/mise-composite
branch
from
3dde0c7 to
6fd19ec
Compare
- Add temporal 1.7.2, cargo-component 0.21.1, cargo-msrv 0.19.3 to mise.toml (versions pinned per 2-week minimum age policy) - Remove redundant 'rustup component add rustfmt clippy' (2 places) Already declared in rust-toolchain.toml components - Remove 'cargo install cargo-msrv' (now via mise) - Remove 'cargo install --locked cargo-component' (now via mise) - Remove 'temporalio/setup-temporal' action (now via mise) - Add missing 'cache-bin: false' to wasm-workflow-tests rust-cache - Remove dead 'submodules: recursive' (3 places, no submodules exist) Closes temporalio#1383
…alls Extract the repeated 4-step setup pattern (rust-toolchain, mise-action, Set PROTOC, rust-cache) into .github/actions/setup/action.yml. All 10 CI jobs across per-pr.yml and heavy.yml now use the composite action with selective mise installs via 'mise-install-args': - 7 jobs: protoc only - msrv: protoc + cargo-msrv - wasm-workflow-tests: protoc + cargo-component - examples: protoc + temporal This avoids installing all mise tools in every job and reduces per-pr.yml from ~330 lines to ~250 lines.
brucearctor
force-pushed
the
feat/mise-composite
branch
from
6fd19ec to
b27a43d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the repeated 4-step CI setup pattern into a reusable composite action and add selective mise tool installation per job.
PR 2 of 3 — depends on #1386. See #1383 for the full effort.
Changes
.github/actions/setup/action.yml(new)Composite action encapsulating:
dtolnay/rust-toolchain(stable viarust-toolchain.toml)jdx/mise-action(with configurableinstall_args)Set PROTOCenv varSwatinem/rust-cache(withcache-bin: false)Inputs:
mise-install-args,rust-cache-key,save-cacheper-pr.yml— refactor all 9 jobsEach job now uses:
Selective installs by job:
protoconlyprotoc cargo:cargo-msrvprotoc cargo:cargo-componentprotoc temporalheavy.yml— same refactorReduces per-pr.yml from ~325 lines to ~248 lines (-24%).
Depends on #1386
Ref #1383