feat(sdk): gate experimental APIs behind feature#1395
Open
chris-olszewski wants to merge 1 commit into
Open
Conversation
chris-olszewski
commented
Jul 11, 2026
|
|
||
| /// Optionally enable Eager Workflow Start, a latency optimization using local workers | ||
| /// NOTE: Experimental | ||
| #[cfg(feature = "experimental")] |
Member
Author
There was a problem hiding this comment.
Is this really still experimental?
chris-olszewski
marked this pull request as ready for review
July 11, 2026 00:49
Member
|
Still kinda on the fence about if I want to do it this way with actual gates. Feels like it'll make it harder to get feedback on new stuff. Perhaps just experimental in the docstring is sufficient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
experimentalfeature gate.Why?
Make it explicit at a language level what APIs are experimental compared to just a comment.
Checklist
Closes N/A
How was this tested:
Existing test suite, ensured we still check that crates compile without feature enabled in CI
Any docs updates needed?
N/A