Fix greedy sed in release.yml and restore cert-manager constraint#255
Merged
Fix greedy sed in release.yml and restore cert-manager constraint#255
Conversation
The sed commands in release.yml matched all `version:` lines including indented dependency versions, causing cert-manager's version constraint to be overwritten on every release. Anchor with `^` to only match top-level chart version. Also restore cert-manager to ">=v1.0.0" and update Chart.lock. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
">=v1.0.0"(was overwritten to0.24.0by thev1.5.1release pipeline)sedcommands inrelease.ymluseds/version: .*/...which matched allversion:lines, including indented dependency versions. Now anchored with^to only match the top-level chart versionChart.lockto be in sync with the restoredChart.yamlContext
When the
v1.5.1release was published,release.yml's helm job:">=v1.0.0"to0.24.0(same bug as Revert cert-manager version constraint to ">=v1.0.0" from 0.23.0 wrongly added by CI #252)helm packagethen failed because cert-manager0.24.0doesn't exist in the jetstack repo0.24.0was never published, but the CRDs chart0.24.0wasAfter merge
Trigger
helm.ymlmanually withversion_bump: none,ref: mainto publish the controller chart0.24.0withappVersion: 1.5.1.Test plan
helm.ymlwithversion_bump: none,ref: main0.24.0is published to Docker Hub🤖 Generated with Claude Code