This repository was archived by the owner on Apr 23, 2021. It is now read-only.
Open
Conversation
Contributor
|
What specifically does not work with roundtripping? Is it the parser? |
Contributor
|
@ftynse yes, we can't use the standard LLVM type parser to support named structs. It relies on the fact that the struct types have already been printed/parsed and elides the body. To support these we will likely need to re-implement the parser in MLIR that supports inline parsing/printing. |
Contributor
Author
To echo River's response, yes, the problem is with the parser. |
joker-eph
force-pushed
the
master
branch
3 times, most recently
from
48dcae0 to
3722f03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add constructors for LLVM identified struct types. This is to support recursive type references. The interface follows that found in LLVM:;StructType's public interface with create and setBody functions.
The test for this is commented out because roundtripping does not work. However, using the interface does generate the expected LLVM code.