Conversation
❌ Deploy Preview for testing-library failed.
|
|
Thanks Tim! As far as I was able to see, there are also some visual changes, if you want I can have a look at those listed here: |
|
You're right @MatanBobi |
|
@timdeschryver i saw that they've released a new RC using MDX 3 today (or maybe that was yesterday?) Are we waiting for the official release to merge this? I haven't had the time to review it yet so just wanted to know the urgency. |
|
It can wait @MatanBobi |
|
Thanks, I've updated to RC 1 (latest). Would it make sense to compare against the latest version of our template too? |
|
3.0.0 is released, I will update the PR later this week. |
|
I can help with updating the PR, but I'd like to block it on #1339 so we don't have to manually add pnpm to the docs. |
5aa61a9 to
f74b33f
Compare
MatanBobi
left a comment
There was a problem hiding this comment.
I've browsed through the site and things look good :)
If it's ready in your opinion, feel free to merge this.
Thanks Tim!
|
Thanks @MatanBobi , I'd like to wait on @nickmccurdy 's review |
|
Working on this a bit more by reviewing nitpicks and Docusaurus docs. Have we done any visual comparisons yet or should I try? |
I made a quick browse (but haven't looked at all of the pages) and AFAIR, @timdeschryver also did. |
|
Great, thanks.
|
@MatanBobi and myself have done some manual tests.
AFAIK, we're not using MDX, just plain markdown. So this doesn't affect us too much. |
We can use visual regression tests for this. However, it requires setting up additional infrastructure, so I'd prefer to investigate after. For now we should be fine, I forgot you both tested manually. |
@timdeschryver I think we are using MDX features, I think this is an example, right? |
|
What's the status with this PR, do we need to take further actions? |
|
I'm still working on it, hopefully some more next week. |
|
After updates, we can do this thing at root config ^_^ |
I wanted to see the impact of upgrading docusaurus, but everything seemed fined locally.
This is a test to verify that our pipeline still works.