add PEP 723 script detection and activation#11
Open
Weidav wants to merge 2 commits intoteticio:mainfrom
Open
Conversation
Owner
|
Hi First of all, thanks for picking this up and doing the work. I've been recovering from a motorcycle accident for a while, so I didn't get around to looking into it. I have to say, I'm not completely convinced it makes sense to do this. It feels like it is a bit at odds with the purpose of the extension. I can only think of a use case where you have a script depending on a venv that is managed outside of the project that you want to debug for some reason, so you click on it and run "Debug Python File" and it loads the correct venv. Can you help me understand the use cases better? I will leave this open for the time being. If anyone else coming here thinks this is useful, please let me know and ideally help me to understand how. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added PEP 723 support as requested in #10
Checks for PEP 723 compatible scripts and, searches for the venv path by running
uv python find --scriptan activates tit.