Repository navigation
The 'Validate' attribute works with a string passed - #48
Merged
moufmouf merged 4 commits intoOct 28, 2026
Merged
Conversation
Fix the 'Validate' Attribute. Currently the 'rule' property passed to
the Validate constructor was normalized but wrong value was checked.
Now the Validate attribute should works properly if it's initialized
with something like this:
```php
<?php
class Foo {
public function bar(
#[Validate('some-rule')]
string $name
): string {
return 'ok';
}
}
```
- Accept Doctrine's positional "value" key (@Validate("email")) - Reject non-string rules with a clear error instead of a later TypeError - Accept "0" as a rule (strict check instead of empty()) - Fix #[Validate(...)] syntax in the error message - Fix ValidateTest namespace, use plain PHPUnit TestCase, add edge-case tests - Exercise the $bar parameter in testValidatorForParameterPHP8 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Thanks a lot and very sorry for not noticing your PR waaaaay earlier :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the
ValidateAttribute. Currently the'rule'argument passed to theValidateconstructor is normalized but if the variable type isstring, then it's not handled properly. Now the Validate attribute works properly if it's initialized with something like this: