fix(datepicker): display raw day numbers for all locales#1667
fix(datepicker): display raw day numbers for all locales#1667seojcarlos wants to merge 2 commits intothemesberg:mainfrom
Conversation
…strings
For locales like ja-JP, zh-CN, and ko-KR, Intl.DateTimeFormat with
{ day: "numeric" } appends locale-specific suffixes (e.g. "1日" instead
of "1"). Calendar UIs universally display bare numbers, so we use
Date.getDate() directly, which is consistent with standard datepicker
behavior across all locales.
Fixes themesberg#1453
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 9504c55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@seojcarlos is attempting to deploy a commit to the Bergside Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe Datepicker day-label rendering was changed to use the native Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Date.getDate()instead ofIntl.DateTimeFormat({ day: "numeric" })for calendar day cellsChanges
packages/ui/src/components/Datepicker/Views/Days.tsx: ReplacegetFormattedDate()call withcurrentDate.getDate()getFormattedDateimportTest plan
Fixes #1453
🤖 Generated with Claude Code
Summary by CodeRabbit
Refactor
Chores