ASoC: SOF: Intel: hda: add SDCA property check #5652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macchian
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart,
ranj063 and
ujfalusi
as code owners
macchian
force-pushed
the
dev-sdw-default
branch
from
3a21abb to
c85ab51
Compare
bardliao
reviewed
Jan 22, 2026
bardliao
reviewed
Jan 22, 2026
macchian
force-pushed
the
dev-sdw-default
branch
from
c85ab51 to
eabcc9e
Compare
lgirdwood
reviewed
Jan 26, 2026
|
|
||
| /* If SDCA is not present, assume the endpoint is present */ | ||
| if (!sdw_device->sdca_data.interface_revision) { | ||
| dev_warn(&sdw_device->dev, "SDCA properties not found in BIOS\n"); |
Member
There was a problem hiding this comment.
we should probably say which endpoint to assist with integration/debug.
Collaborator
There was a problem hiding this comment.
@lgirdwood If no sdca_data.interface_revision found means there is no SDCA properties at all. It is not just missing a specific endpoint. Also, we can't tell if an endpoint is missed or not present.
If SDCA property is not present in the DisCo table, assume it is present. This allows DAI links to be created from codec_info_list instead of being skipped. Signed-off-by: Mac Chiang <mac.chiang@intel.com>
macchian
force-pushed
the
dev-sdw-default
branch
from
eabcc9e to
b98689b
Compare
bardliao
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If SDCA property is not present in the DisCo table, do not skip codec dai endpoints. This ensures that dai links can still be
created from codec_info_list instead of being ignored.
By enabling the default SoundWire driver and best_effort tplg on PTL, functional topologies work on RT721 and multi-lane amplifier on link 3.