Audio: Buffers: Add support for DP-to-DP component binding by singalsu · Pull Request #10562 · thesofproject/sof

singalsu · 2026-02-20T10:12:08Z

Previously binding two DP (Data Processing) scheduled components was rejected with IPC4_INVALID_REQUEST. This patch adds support for DP-to-DP binding by creating a dual ring buffer configuration where each DP module gets its own ring buffer on either side of the intermediate comp_buffer.

Data flow for DP-to-DP:
src_DP -> ring_buf_src -> comp_buffer -> ring_buf_sink -> sink_DP

Changes in helper.c:

Remove the DP-to-DP bind rejection in ipc_comp_connect().
Add src_is_dp, sink_is_dp, and dp_to_dp flags to detect the DP-to-DP case.
Create a second ring_buffer allocated from the source module's heap for the source side of the comp_buffer.
Track ring_buffer client_count on the DP heap with a NULL guard to avoid unsafe container_of when CONFIG_USERSPACE is disabled.

Changes in audio_buffer.c:

Change audio_buffer_attach_secondary_buffer() from a global rejection to per-side checks, allowing both secondary_buffer_sink and secondary_buffer_source to be set simultaneously.
Add a dual-secondary sync path in audio_buffer_sync_secondary_buffer()
that cascades data through: input ring_buffer -> comp_buffer ->
output ring_buffer, with rate-limiting applied on the output side.

Changes in ring_buffer.c:

Add DP heap client_count decrement in ring_buffer_free() with a NULL heap guard, matching the pattern used in comp_buffer_free().

lgirdwood

@singalsu so this is not breaking anything atm, but its probably worth while to modify the nocodec topology to have this DP-DP config and see what happens...

softwarecki · 2026-02-20T15:59:08Z

No, no, no! No comp_buffer between dp modules! Just single ring buffer. We plan to remove comp_buffer and add support for dp-dp connection.

singalsu · 2026-02-20T16:03:49Z

No, no, no! No comp_buffer between dp modules! Just single ring buffer. We plan to remove comp_buffer and add support for dp-dp connection.

Would be great if that can be done! I need this to have decoder and phase_vocoder in same pipeline without LL components in between throttling the playback data. The phase vocoder consumes at input the audio data at 0.5x to 2.0x speed vs. normal. There can't be LL components with speed higher than 1.0.

lgirdwood · 2026-02-23T12:14:05Z

No, no, no! No comp_buffer between dp modules! Just single ring buffer. We plan to remove comp_buffer and add support for dp-dp connection.

Would be great if that can be done! I need this to have decoder and phase_vocoder in same pipeline without LL components in between throttling the playback data. The phase vocoder consumes at input the audio data at 0.5x to 2.0x speed vs. normal. There can't be LL components with speed higher than 1.0.

@softwarecki whats your rough schedule for dp-dp ? It seems like we have a real use case now that needs it.

Copilot

Pull request overview

This PR extends the IPC4 binding and buffering infrastructure to allow binding two DP-scheduled components together by introducing a dual-ring-buffer “hybrid” topology around an intermediate comp_buffer, enabling lock-free DP access on both sides while preserving LL-cycle synchronization semantics.

Changes:

Allow DP→DP binds in ipc_comp_connect() and create/attach a second ring_buffer for the source side in the DP→DP case.
Update secondary-buffer attachment and syncing logic to permit and handle both secondary_buffer_sink and secondary_buffer_source simultaneously.
Add vregion refcount release in ring_buffer_free() to match new vregion refcounting during ring buffer creation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/ipc/ipc4/helper.c	Removes DP→DP bind rejection and adds dual ring-buffer creation/attachment for DP→DP connections.
src/audio/buffers/audio_buffer.c	Allows per-side secondary attachments and adds a dual-secondary sync path for DP→DP cascaded copying.
src/audio/buffers/ring_buffer.c	Releases vregion references during ring buffer free to match new vregion refcounting behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

See thesofproject#10562 Previously binding two DP (Data Processing) scheduled components was rejected with IPC4_INVALID_REQUEST. This patch adds support for DP-to-DP binding by creating a dual ring buffer configuration where each DP module gets its own ring buffer on either side of the intermediate comp_buffer. Data flow for DP-to-DP: src_DP -> ring_buf_src -> comp_buffer -> ring_buf_sink -> sink_DP Changes in helper.c: - Remove the DP-to-DP bind rejection in ipc_comp_connect(). - Add src_is_dp, sink_is_dp, and dp_to_dp flags to detect the DP-to-DP case. - Create a second ring_buffer allocated from the source module's mod_alloc_ctx for the source side of the comp_buffer. - Refcount the DP vregion for each created ring_buffer via vregion_get(), with a NULL alloc guard. Changes in audio_buffer.c: - Change audio_buffer_attach_secondary_buffer() from a global rejection to per-side checks, allowing both secondary_buffer_sink and secondary_buffer_source to be set simultaneously. - Add a dual-secondary sync path in audio_buffer_sync_secondary_buffer() that cascades data through: input ring_buffer -> comp_buffer -> output ring_buffer, with rate-limiting applied on the output side. Changes in ring_buffer.c: - Release the DP vregion in ring_buffer_free() via vregion_put() and free the mod_alloc_ctx when the refcount reaches zero, matching the pattern used in comp_buffer_free(). Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

lgirdwood · 2026-08-21T13:08:35Z

@softwarecki @abonislawski this is needed very soon, do you have an ETA or can we go ahead here in the short term.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

singalsu · 2026-08-24T10:34:39Z

I just tested this updated patch with #11092, and it worked OK.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

lgirdwood

@singalsu can we the logic behind a Kconfig so it will become easier to update when pipeline 2.0 is ready.

lgirdwood · 2026-08-25T14:16:22Z

 		 * to ring_buffer (as sink)
 		 */
-		err = audio_buffer_sync_secondary_buffer(&buffer->audio_buffer, UINT_MAX);
+		err = audio_buffer_sync_secondary_buffer(&buffer->audio_buffer, SIZE_MAX);


separate commit ?

Yep, done. Also I used CONFIG_DP_TO_DP_BIND to help find the code for this.

lgirdwood · 2026-08-25T14:18:10Z

 	sof_ctx_free(alloc, (__sparse_force void *)ring_buffer->_data_buffer);
 	sof_ctx_free(alloc, ring_buffer);
+
+	/* matches vregion_get() in ipc_comp_connect() for each ring_buffer */


can we state this is just for DP to DP.

…uffer() The limit parameter of audio_buffer_sync_secondary_buffer() is of type size_t. Pass SIZE_MAX instead of UINT_MAX for the unlimited input copy to match the parameter type and avoid size mismatches on 64-bit platforms. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

Previously binding two DP (Data Processing) scheduled components was rejected with IPC4_INVALID_REQUEST. This patch adds support for DP-to-DP binding by creating a dual ring buffer configuration where each DP module gets its own ring buffer on either side of the intermediate comp_buffer. Data flow for DP-to-DP: src_DP -> ring_buf_src -> comp_buffer -> ring_buf_sink -> sink_DP Changes in Kconfig: - Add CONFIG_DP_TO_DP_BIND (default y) depending on CONFIG_ZEPHYR_DP_SCHEDULER to allow enabling/disabling DP-to-DP component binding. Changes in helper.c: - Allow DP-to-DP binding when CONFIG_DP_TO_DP_BIND is enabled; reject with IPC4_INVALID_REQUEST when disabled. - Add src_is_dp, sink_is_dp, and dp_to_dp flags to detect the DP-to-DP case. - Create a second ring_buffer allocated from the source module's mod_alloc_ctx for the source side of the comp_buffer. - Refcount the DP vregion for each created ring_buffer via vregion_get(), guarded by CONFIG_DP_TO_DP_BIND. Changes in audio_buffer.c: - When CONFIG_DP_TO_DP_BIND is enabled, change audio_buffer_attach_secondary_buffer() from a global rejection to per-side checks, allowing both secondary_buffer_sink and secondary_buffer_source to be set simultaneously. - Add a dual-secondary sync path in audio_buffer_sync_secondary_buffer() under CONFIG_DP_TO_DP_BIND that cascades data through: input ring_buffer -> comp_buffer -> output ring_buffer, with rate-limiting applied on the output side. Changes in ring_buffer.c: - For DP-to-DP binding, release the DP vregion in ring_buffer_free() via vregion_put() and free the mod_alloc_ctx when the refcount reaches zero, guarded by CONFIG_DP_TO_DP_BIND. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>

kv2019i

Looks clean. A few questions inline. There are also tests failing, can you take a look at those.

kv2019i · 2026-08-28T11:30:32Z

 int audio_buffer_attach_secondary_buffer(struct sof_audio_buffer *buffer, bool at_input,
 					 struct sof_audio_buffer *secondary_buffer)
 {
+#if CONFIG_DP_TO_DP_BIND


Style note, "#ifdef CONFIG_DP_TO_DP_BIND" is the usual convention. @lyakh agrees, but Linux kernel and statistics of use in SOF are on my side with this.

kv2019i · 2026-08-28T11:38:29Z

+		 * ring_buffer_free for DP-to-DP binding)
+		 */
+		if (ring_buffer->audio_buffer.alloc)
+			vregion_get(ring_buffer->audio_buffer.alloc->vreg);


This I don't fully get. Why do we need an additional vregion_get/put on the ringbuffer that we already allocated in the normal single DP case. This seems correct, but I'm puzzled why this ref is not taken in ring_buffer_create(). @lyakh any thoughts?

kv2019i · 2026-08-28T11:39:33Z

+						   MAX(obs, src_module_data->mpd.out_buff_size),
+						   is_shared, buf_id);
+			if (!ring_buffer2) {
+				buffer_free(buffer);


How about the first ring_buffer we allocated (and the vregion ref), should we free those here?

lgirdwood reviewed Feb 20, 2026

View reviewed changes

softwarecki self-requested a review February 20, 2026 15:56

singalsu mentioned this pull request Aug 14, 2026

audio: tensorflow: keyword detect #11092

Draft

singalsu force-pushed the audio_buffers_dp_to_dp_bind branch from 46ecff9 to cdc456a Compare August 14, 2026 08:17

singalsu changed the title ~~[DNM] Audio: Buffers: Add support for DP-to-DP component binding~~ Audio: Buffers: Add support for DP-to-DP component binding Aug 14, 2026

singalsu marked this pull request as ready for review August 14, 2026 08:18

singalsu requested review from mmaka1 and plbossart as code owners August 14, 2026 08:18

Copilot AI lite review requested due to automatic review settings August 14, 2026 08:18

singalsu requested review from dbaluta, kv2019i and lbetlej as code owners August 14, 2026 08:18

Copilot started reviewing on behalf of singalsu August 14, 2026 08:20 View session

Copilot AI reviewed Aug 14, 2026

View reviewed changes

Comment thread src/audio/buffers/audio_buffer.c Outdated

singalsu force-pushed the audio_buffers_dp_to_dp_bind branch from cdc456a to 70ff3f1 Compare August 24, 2026 10:17

singalsu requested a lite review from Copilot August 24, 2026 10:17

Copilot started reviewing on behalf of singalsu August 24, 2026 10:23 View session

Copilot AI reviewed Aug 24, 2026

View reviewed changes

Comment thread src/ipc/ipc4/helper.c Outdated

Comment thread src/audio/buffers/audio_buffer.c

singalsu force-pushed the audio_buffers_dp_to_dp_bind branch from 70ff3f1 to 0570d14 Compare August 24, 2026 10:41

singalsu requested a review from ranj063 as a code owner August 24, 2026 10:41

singalsu requested a lite review from Copilot August 24, 2026 10:45

Copilot started reviewing on behalf of singalsu August 24, 2026 10:45 View session

Copilot AI reviewed Aug 24, 2026

View reviewed changes

Comment thread src/audio/module_adapter/module_adapter.c Outdated

singalsu force-pushed the audio_buffers_dp_to_dp_bind branch from 0570d14 to 58d6216 Compare August 24, 2026 10:59

lgirdwood reviewed Aug 25, 2026

View reviewed changes

singalsu added 2 commits August 28, 2026 12:06

singalsu force-pushed the audio_buffers_dp_to_dp_bind branch from 58d6216 to 7c41c51 Compare August 28, 2026 09:12

singalsu requested review from abonislawski, iuliana-prodan and lyakh as code owners August 28, 2026 09:12

singalsu requested a review from lgirdwood August 28, 2026 09:27

kv2019i requested changes Aug 28, 2026

View reviewed changes

Uh oh!

Conversation

singalsu commented Feb 20, 2026

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

softwarecki commented Feb 20, 2026

Uh oh!

singalsu commented Feb 20, 2026

Uh oh!

lgirdwood commented Feb 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

lgirdwood commented Aug 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

singalsu commented Aug 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

lgirdwood Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

singalsu Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

lgirdwood Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

kv2019i Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

kv2019i Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

kv2019i Aug 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lgirdwood Aug 25, 2026 •

edited

Loading