rimage: minor fixes - #11122
Merged
Merged
Conversation
Leave unsupported SUE and ACE MEU callbacks unset and report a runtime error before writer dispatch. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Reject relocatable manifest creation when the TOML configuration does not provide module metadata. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
Test the outcome of the scan instead of the loop index, so the check no longer depends on the loop bound, and align the message with the one used by verify_image(). Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
abonislawski
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
August 25, 2026 09:11
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes small robustness fixes to the rimage tool, primarily by replacing assertions/implicit assumptions with explicit user-facing errors and by disabling MEU signing paths for targets that don’t support them.
Changes:
- Reject MEU signing early when the selected target does not provide a
write_firmware_meu()implementation (replaces anassert()-style failure with a clear CLI error). - Fail fast when building relocatable images without TOML module configuration, avoiding null dereferences later.
- Improve resigning error handling/messages when scanning input binaries for the
$CPDCSE header marker.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/rimage/src/rimage.c | Adds an explicit early error for unsupported MEU signing targets and removes a runtime assert before calling the MEU writer. |
| tools/rimage/src/manifest.c | Adds a required-config check for relocatable image module handling and improves $CPD header-not-found detection/message during resign. |
| tools/rimage/src/adsp_config.c | Disables MEU signing for specific manifest configurations by setting write_firmware_meu to NULL, aligning behavior with the new CLI guard. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lgirdwood
approved these changes
Aug 25, 2026
kv2019i
approved these changes
Aug 26, 2026
Collaborator
|
Testbench fail known, not related to this PR. Proceeding with merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.