-
Notifications
You must be signed in to change notification settings - Fork 675
docs(portal): fix syntax and compilation errors in v5 guide snippets #8845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TanmayDagur
wants to merge
1
commit into
thirdweb-dev:main
Choose a base branch
from
TanmayDagur:fix/portal-code-snippets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−4
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: thirdweb-dev/js
Length of output: 9328
🌐 Web query:
thirdweb privateKeyToAccount undefined replace source code💡 Result:
If you are encountering an undefined error when using privateKeyToAccount in the thirdweb TypeScript SDK, please note that the function has been renamed to privateKeyAccount in newer versions of the SDK [1]. To resolve this, update your import and usage as follows: 1. Update your import: import { privateKeyAccount } from "thirdweb/wallets"; 2. Update your implementation: const account = privateKeyAccount({ client, privateKey: process.env.PRIVATE_KEY as string, }); If you were previously relying on the source code implementation of privateKeyToAccount, it is worth noting that the internal implementation automatically handles prefixing the private key with 0x [2]: const privateKey =
0x${options.privateKey.replace(/^0x/, "")}satisfies Hex; If you continue to face runtime or build errors (such as issues in specific environments like Expo), ensure your SDK is updated to the latest version [3], as bug fixes related to import/build errors are frequently released [3]. Top results: [3] #3299 [2] https://cdn.jsdelivr.net/npm/thirdweb@5.116.1/src/wallets/private-key.ts [1] https://portal.thirdweb.com/typescript/v5/account-abstraction/get-startedCitations:
🏁 Script executed:
Repository: thirdweb-dev/js
Length of output: 2747
Guard
THIRDWEB_PRIVATE_KEYbefore constructing the account.privateKeyToAccountdereferencesprivateKeyimmediately, so this example will throw on startup if the env var is missing. Add an explicit check before the call.🤖 Prompt for AI Agents