Replace privateKeyId with wallet-based signing config#14
Draft
Replace privateKeyId with wallet-based signing config#14
Conversation
Replace privateKeyId with signingAddress and signingPublicKey in the config layer. The signing address and public key are resolved during setup and stored directly in the config file, eliminating runtime API calls for key lookup. The TURNKEY_PRIVATE_KEY_ID environment variable is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
privateKeyId/TURNKEY_PRIVATE_KEY_IDwithsigningAddressandsigningPublicKeyin the config layerget_public_key()is now sync (decodes hex from config, no API call)sign_ed25519()uses the stored signing address directlysign_ssh_auth_payloadintosign_ed25519The pre-existing
ssh_agent_start_uses_default_socket_path_when_socket_is_omittedtest failure is not introduced by this PR (fails on main).Test plan
cargo test --allpasses (12/13, 1 pre-existing failure)cargo build --all-targetscleanprivateKeyIdorTURNKEY_PRIVATE_KEY_IDPR 1 of 3 (base: main)