Fix questionable cast to abstract collection in ListResult and SetResult#138
Open
Fix questionable cast to abstract collection in ListResult and SetResult#138
Conversation
Instead of casting the parent's collection field, store the specific collection types (List<T> and Set<T>) as separate fields in ListResult and SetResult respectively. This eliminates the SpotBugs BC_BAD_CAST_TO_ABSTRACT_COLLECTION warnings. The changes: - Added private final List<T> field to ListResult - Added private final Set<T> field to SetResult - Modified getList() and getSet() to return the stored fields instead of casting - Added comprehensive unit tests for both classes Fixes #67
Contributor
|
This PR needs a little more work and is intertwined with the JSON serialization rework (merging like this will most likely cause double serialization of the list / set). I will keep this open until I got to check JSON annotation in Scanner-Core. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the SpotBugs BC_BAD_CAST_TO_ABSTRACT_COLLECTION warnings in ListResult and SetResult classes.
Summary
The issue was that both classes were casting the parent class's field to more specific types ( and ). This is problematic because there's no guarantee the collection is of the expected type.
Changes
Testing
Fixes #67