fix(spark): parse SQL scripting compound blocks#7840
Open
judahrand wants to merge 1 commit into
Open
Conversation
Collaborator
|
I don't think this is the right approach:
Based on Spark's grammar, I think we should override the statement parser for Spark and map it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed fix to #7838. I appreciate that this does not fundamentally fix the underlying lack of mature support for imperative SQL. However, it does allow SQL script blocks to roundtrip. I can also understand that this doesn't really solve the issue for transpiling between dialects which is a core
sqlglotfunctionality. So based on that please feel free to close - I figured the approach might spark some idea in someone else.