feat(grammar): Refactor modifiers for better querying#211
Open
lightless233 wants to merge 1 commit intotree-sitter:masterfrom
Open
feat(grammar): Refactor modifiers for better querying#211lightless233 wants to merge 1 commit intotree-sitter:masterfrom
lightless233 wants to merge 1 commit intotree-sitter:masterfrom
Conversation
|
Not a maintainer, but thank you for your PR! I have integrated it in this fork (alongside other unreviewed PRs) and the change turned out to be very helpful in Mergiraf. Since you seem to be using this grammar from Rust, maybe you're interested in switching to the fork ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #204.
Right now, modifiers like
publicorstaticare just anonymous keywords in the AST. This makes it a pain to write queries for them without matching on text.This PR makes them actual nodes, similar to how
tree-sitter-typescripthandles it.Changes:
New
(visibility)node:public,protected,privateare now grouped under this node.New
(modifier)node:static,final,abstract, etc., now all produce a(modifier)node.Resulting AST:
For
public static class..., the AST is now much cleaner:Closes #204.