Skip to content

chore: bump internal node to 22 and standardise #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carderne merged 9 commits into from
Jul 2, 2026
+1,125 −799
Merged

chore: bump internal node to 22 and standardise #4084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d0f562c
chore: bump internal node to 22
carderne Jun 30, 2026
6f1b748
fix(clickhouse): type row.json() as any[] to match sibling loop
carderne Jun 30, 2026
53896a1
fix review comments
carderne Jun 30, 2026
50715d8
fix agents.md
carderne Jun 30, 2026
4dd7e63
single node for testbox
carderne Jun 30, 2026
aee53a7
update missed containerfiles to node 22
carderne Jul 2, 2026
eff4a95
update another nvmrc and more types/node although already overridden …
carderne Jul 2, 2026
b1fd018
update test fixture to pnpm@10 and update pnpm+yarn lockfiles
carderne Jul 2, 2026
74126c8
update npm lockfile
carderne Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/changesets-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
cache: "pnpm"

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/claude.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
cache: "pnpm"

- name: 📥 Download deps
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
cache: "pnpm"

- name: 📥 Download deps
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-webapp-auth-full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
cache: "pnpm"

- name: 🐳 Login to DockerHub
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-webapp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
cache: "pnpm"

# ..to avoid rate limits when pulling images
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1

- name: 📥 Download deps
run: pnpm install --frozen-lockfile --filter trigger.dev...
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-testbox-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1

- name: 📥 Download CLI deps
run: pnpm install --frozen-lockfile --filter trigger.dev...
Expand Down
9 changes: 2 additions & 7 deletions .github/workflows/pr-testbox.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,15 +61,10 @@ jobs:
with:
version: 10.33.2

- name: ⎔ Setup Node 22 for SDK compatibility checks
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 22.12

- name: ⎔ Setup active Node 20
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
Comment thread
carderne marked this conversation as resolved.
cache: "pnpm"

- name: 🥟 Setup Bun
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/preview-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.0
node-version: 22.23.1
cache: "pnpm"

- name: 📥 Install dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
cache: "pnpm"

# npm v11.5.1 or newer is required for OIDC support
Expand Down Expand Up @@ -288,7 +288,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
cache: "pnpm"

# npm v11.5.1 or newer is required for OIDC support
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/sdk-compat.yml
View file
Open in desktop
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
os: [blacksmith-4vcpu-ubuntu-2404]
node: ["20.20", "22.12"]
node: ["20.20", "22.23", "24.18", "26.4"]
Comment thread
carderne marked this conversation as resolved.

steps:
- name: ⬇️ Checkout repo
Expand Down Expand Up @@ -70,7 +70,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
cache: "pnpm"

- name: 🥟 Setup Bun
Expand Down Expand Up @@ -112,7 +112,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
cache: "pnpm"

- name: 🦕 Setup Deno
Expand Down Expand Up @@ -158,7 +158,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
cache: "pnpm"

- name: 📥 Download deps
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/typecheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
cache: "pnpm"
Comment thread
coderabbitai[bot] marked this conversation as resolved.

- name: 📥 Download deps
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit-tests-internal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
cache: "pnpm"

# ..to avoid rate limits when pulling images
Expand Down Expand Up @@ -146,7 +146,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
# no cache enabled, we're not installing deps

- name: Download blob reports from GitHub Actions Artifacts
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit-tests-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
cache: "pnpm"

# ..to avoid rate limits when pulling images
Expand Down Expand Up @@ -146,7 +146,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
# no cache enabled, we're not installing deps

- name: Download blob reports from GitHub Actions Artifacts
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit-tests-webapp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
cache: "pnpm"

# ..to avoid rate limits when pulling images
Expand Down Expand Up @@ -155,7 +155,7 @@ jobs:
- name: ⎔ Setup node
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
with:
node-version: 20.20.2
node-version: 22.23.1
# no cache enabled, we're not installing deps

- name: Download blob reports from GitHub Actions Artifacts
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Comment thread
carderne marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v20.20.2
v22.23.1
Comment thread
carderne marked this conversation as resolved.
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ This repository is a pnpm monorepo managed with Turbo. It contains multiple apps
See `ai/references/repo.md` for a more complete explanation of the workspaces.

## Development setup
1. Install dependencies with `pnpm i` (pnpm `10.33.2` and Node.js `20.20.2` are required).
1. Install dependencies with `pnpm i` (pnpm `10.33.2` and Node.js `22.23.1` are required).
2. Copy `.env.example` to `.env` and generate a random 16 byte hex string for `ENCRYPTION_KEY` (`openssl rand -hex 16`). Update other secrets if needed.
3. Start the local services with Docker:
```bash
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ branch are tagged into a release periodically.

### Prerequisites

- [Node.js](https://nodejs.org/en) version 20.20.2
- [Node.js](https://nodejs.org/en) version 22.23.1
Comment thread
coderabbitai[bot] marked this conversation as resolved.
- [pnpm package manager](https://pnpm.io/installation) version 10.33.2
- [Docker](https://www.docker.com/get-started/)
- [protobuf](https://github.com/protocolbuffers/protobuf)
Expand All @@ -49,7 +49,7 @@ branch are tagged into a release periodically.
```
cd trigger.dev
```
3. Ensure you are on the correct version of Node.js (20.20.2). If you are using `nvm`, there is an `.nvmrc` file that will automatically select the correct version of Node.js when you navigate to the repository.
3. Ensure you are on the correct version of Node.js (22.23.1). If you are using `nvm`, there is an `.nvmrc` file that will automatically select the correct version of Node.js when you navigate to the repository.

4. Run `corepack enable` to use the correct version of pnpm (`10.33.2`) as specified in the root `package.json` file.

Expand Down
6 changes: 3 additions & 3 deletions apps/coordinator/Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
# syntax=docker/dockerfile:labs

FROM node:20-bookworm-slim@sha256:72f2f046a5f8468db28730b990b37de63ce93fd1a72a40f531d6aa82afdf0d46 AS node-20
FROM node:22.23.1-bookworm-slim@sha256:813a7480f28fdadac1f7f5c824bcdad435b5bc1322a5968bbbdef8d058f9dff4 AS node-22

WORKDIR /app

FROM node-20 AS pruner
FROM node-22 AS pruner

COPY --chown=node:node . .
RUN npx -q turbo@1.10.9 prune --scope=coordinator --docker
RUN find . -name "node_modules" -type d -prune -exec rm -rf '{}' +

FROM node-20 AS base
FROM node-22 AS base

RUN apt-get update \
&& apt-get install -y buildah ca-certificates dumb-init docker.io busybox \
Expand Down
6 changes: 3 additions & 3 deletions apps/docker-provider/Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
FROM node:20-alpine@sha256:7a91aa397f2e2dfbfcdad2e2d72599f374e0b0172be1d86eeb73f1d33f36a4b2 AS node-20-alpine
FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS node-22-alpine

WORKDIR /app

FROM node-20-alpine AS pruner
FROM node-22-alpine AS pruner

COPY --chown=node:node . .
RUN npx -q turbo@1.10.9 prune --scope=docker-provider --docker
RUN find . -name "node_modules" -type d -prune -exec rm -rf '{}' +

FROM node-20-alpine AS base
FROM node-22-alpine AS base

RUN apk add --no-cache dumb-init docker

Expand Down
6 changes: 3 additions & 3 deletions apps/kubernetes-provider/Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
FROM node:20-alpine@sha256:7a91aa397f2e2dfbfcdad2e2d72599f374e0b0172be1d86eeb73f1d33f36a4b2 AS node-20-alpine
FROM node:22-alpine@sha256:9bef0ef1e268f60627da9ba7d7605e8831d5b56ad07487d24d1aa386336d1944 AS node-22-alpine

WORKDIR /app

FROM node-20-alpine AS pruner
FROM node-22-alpine AS pruner

COPY --chown=node:node . .
RUN npx -q turbo@1.10.9 prune --scope=kubernetes-provider --docker
RUN find . -name "node_modules" -type d -prune -exec rm -rf '{}' +

FROM node-20-alpine AS base
FROM node-22-alpine AS base

RUN apk add --no-cache dumb-init

Expand Down
2 changes: 1 addition & 1 deletion apps/supervisor/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v22.12.0
v22.23.1
2 changes: 1 addition & 1 deletion docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG NODE_IMAGE=node:20.20.2-bookworm-slim@sha256:2cf067cfed83d5ea958367df9f966191a942351a2df77d6f0193e162b5febfc0
ARG NODE_IMAGE=node:22.23.1-bookworm-slim@sha256:813a7480f28fdadac1f7f5c824bcdad435b5bc1322a5968bbbdef8d058f9dff4
Comment thread
carderne marked this conversation as resolved.

FROM golang:1.26-alpine AS goose_builder
RUN go install github.com/pressly/goose/v3/cmd/goose@v3.27.1
Expand Down
2 changes: 1 addition & 1 deletion internal-packages/clickhouse/src/client/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ export class ClickhouseClient implements ClickhouseReader, ClickhouseWriter {
}

for (const row of rows) {
const rowData = row.json();
const rowData = row.json() as any[];

const hydratedRow: Record<string, any> = {};
for (let i = 0; i < req.columns.length; i++) {
Expand Down
2 changes: 1 addition & 1 deletion internal-packages/otlp-importer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"typecheck": "tsc --noEmit"
},
"devDependencies": {
"@types/node": "^20",
"@types/node": "^22.20.0",
"rimraf": "^6.0.1",
"ts-proto": "^1.167.3"
},
Expand Down
2 changes: 1 addition & 1 deletion internal-packages/rbac/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"devDependencies": {
"@trigger.dev/database": "workspace:*",
"@types/node": "^20.14.14",
"@types/node": "^22.20.0",
"rimraf": "6.0.1"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion internal-packages/sso/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"devDependencies": {
"@trigger.dev/database": "workspace:*",
"@types/node": "^20.14.14",
"@types/node": "^22.20.0",
"rimraf": "6.0.1"
},
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"@manypkg/cli": "^0.19.2",
"@playwright/test": "^1.36.2",
"@trigger.dev/database": "workspace:*",
"@types/node": "20.14.14",
"@types/node": "22.20.0",
"@vitest/coverage-v8": "4.1.7",
"autoprefixer": "^10.4.12",
"oxfmt": "^0.54.0",
Expand Down Expand Up @@ -92,7 +92,7 @@
},
"overrides": {
"typescript": "5.5.4",
"@types/node": "20.14.14",
"@types/node": "22.20.0",
"react@^18": "18.3.1",
"react-dom@^18": "18.3.1",
"ai@^6": "6.0.116",
Expand Down
Loading
Loading