feat(core): id-shape residency classifier + ksuid mint primitives (run-ops split base)#4112
feat(core): id-shape residency classifier + ksuid mint primitives (run-ops split base)#4112d-cs wants to merge 4 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…dlyId Production mints ksuid runs explicitly via generateKsuidId() at gated trigger sites; the mutable process-global only ever let tests puppet RunId/WaitpointId.generate() into ksuids and cannot express per-org behavior. Delete setKsuidMintEnabled/isKsuidMintEnabled and the flag branch; generateInternalId() and IdUtil now always mint cuid. Tests drive the ksuid path via generateKsuidId() directly, preserving the 25-vs-27 disjoint-length, k-sortability, uniqueness, and payload round-trip coverage. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
WalkthroughThis PR adds KSUID support to the friendlyId module in 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (4)
packages/core/src/v3/isomorphic/runOpsResidency.ts (1)
8-10: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDuplicate KSUID length constant risks drift.
KSUID_LENGTH = 27here duplicates the privateKSUID_STRING_LENGTH = 27infriendlyId.ts. If the KSUID format ever changes length, only one of the two constants might get updated, silently breaking classification.Consider exporting
KSUID_STRING_LENGTHfromfriendlyId.tsand importing it here instead of redefining it.♻️ Proposed fix
-const KSUID_STRING_LENGTH = 27; +export const KSUID_STRING_LENGTH = 27;+import { KSUID_STRING_LENGTH } from "./friendlyId.js"; + /** KSUID / nanoid-27 emits 27-char ids (ksuid path, flag ON). */ -export const KSUID_LENGTH = 27; +export const KSUID_LENGTH = KSUID_STRING_LENGTH;packages/core/src/v3/isomorphic/runOpsResidency.test.ts (1)
43-47: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winMissing
isClassifiablefalse-case coverage.The malformed-length cases are only verified to throw via
ownerEngine/classifyKind;isClassifiable(the non-throwing predicate) is never asserted to returnfalsefor these same inputs.✅ Proposed addition
it("throws UnclassifiableRunId on malformed lengths (24, 26, 28, empty)", () => { for (const bad of ["", "x".repeat(24), "x".repeat(26), "x".repeat(28), "x".repeat(40)]) { expect(() => ownerEngine(bad)).toThrow(UnclassifiableRunId); + expect(isClassifiable(bad)).toBe(false); } });packages/core/src/v3/isomorphic/friendlyId.test.ts (2)
56-74: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winPrefer the already-imported
decodeKsuidover reimplementing base62 decoding.
decodeTimestamp()hand-rolls base62 decoding and a>> 128nbit-shift to recover the timestamp, duplicating logic thatdecodeKsuid(already imported and exercised elsewhere in this file) is responsible for. If the real alphabet ordering or byte layout infriendlyId.tsever changes, this local reimplementation can silently diverge and either mask a real regression or produce a false failure unrelated todecodeKsuiditself.♻️ Suggested simplification
- // Decode the 27-char base62 body back to the 4-byte timestamp prefix (unix seconds). - function decodeTimestamp(id: string): number { - let n = 0n; - for (const ch of id) n = n * 62n + BigInt(BASE62.indexOf(ch)); - return Number(n >> 128n) + KSUID_EPOCH; // top 4 of the 20 bytes - } - afterEach(() => vi.useRealTimers()); it("is exactly 27 base62 chars", () => { expect(generateKsuidId()).toMatch(/^[0-9A-Za-z]{27}$/); }); it("carries a decodable timestamp within a few seconds of now", () => { const before = Math.floor(Date.now() / 1000); - const ts = decodeTimestamp(generateKsuidId()); + const { timestampSeconds: ts } = decodeKsuid(generateKsuidId()); expect(ts).toBeGreaterThanOrEqual(before - 2); expect(ts).toBeLessThanOrEqual(Math.floor(Date.now() / 1000) + 2); });
86-89: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueImplicit index argument passed to
generateKsuidIdviaArray.frommapFn.
Array.from({ length: n }, generateKsuidId)invokesgenerateKsuidId(undefined, index)for each element (classicmap(parseInt)-style pitfall). This is harmless today since the extraindexarg is ignored, but it's fragile ifgenerateKsuidId's signature ever gains a second parameter.🔧 Suggested fix
- expect(new Set(Array.from({ length: n }, generateKsuidId)).size).toBe(n); + expect(new Set(Array.from({ length: n }, () => generateKsuidId())).size).toBe(n);
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 18e788e2-6937-43c5-990c-67d951c171c5
📒 Files selected for processing (5)
packages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/friendlyId.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/runOpsResidency.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (38)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
- GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
- GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (7, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
- GitHub Check: sdk-compat / Node.js 24.18 (blacksmith-4vcpu-ubuntu-2404)
- GitHub Check: internal / 🧪 Unit Tests: Internal (1, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
- GitHub Check: internal / 🧪 Unit Tests: Internal (12, 12)
- GitHub Check: sdk-compat / Node.js 22.23 (blacksmith-4vcpu-ubuntu-2404)
- GitHub Check: sdk-compat / Node.js 26.4 (blacksmith-4vcpu-ubuntu-2404)
- GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
- GitHub Check: sdk-compat / Node.js 20.20 (blacksmith-4vcpu-ubuntu-2404)
- GitHub Check: sdk-compat / Bun Runtime
- GitHub Check: sdk-compat / Cloudflare Workers
- GitHub Check: packages / 🧪 Unit Tests: Packages (2, 3)
- GitHub Check: packages / 🧪 Unit Tests: Packages (1, 3)
- GitHub Check: typecheck / typecheck
- GitHub Check: packages / 🧪 Unit Tests: Packages (3, 3)
- GitHub Check: e2e / 🧪 CLI v3 tests (blacksmith-4vcpu-ubuntu-2404 - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (blacksmith-4vcpu-windows-2025 - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (blacksmith-4vcpu-windows-2025 - npm)
- GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Build and publish previews
🧰 Additional context used
📓 Path-based instructions (11)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
Files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use vitest for all tests in the Trigger.dev repository
Files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/friendlyId.test.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
packages/core/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (packages/core/CLAUDE.md)
Never import the root package (
@trigger.dev/core). Always use subpath imports such as@trigger.dev/core/v3,@trigger.dev/core/v3/utils,@trigger.dev/core/logger, or@trigger.dev/core/schemas
Files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}: Usepnpm run typecheckfor changes in apps (apps/*) and internal packages (internal-packages/*), and never usebuildto verify those changes.
Use Vitest for tests, and never mock anything; use testcontainers instead.
Prefer static imports over dynamicimport(), and only use dynamic imports for unresolved circular dependencies, genuine code-splitting needs, or conditional runtime loading.
Files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
packages/**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
Use
pnpm run buildto verify changes in public packages (packages/*).
Files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
**/*.{test,spec}.{ts,tsx,js,jsx,mts,cts,mjs,cjs}
📄 CodeRabbit inference engine (CLAUDE.md)
Place test files next to the source files they cover (for example,
MyService.ts->MyService.test.ts).
Files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/friendlyId.test.ts
**/*.{ts,tsx,js,jsx,mts,cts,mjs,cjs,md,mdx}
📄 CodeRabbit inference engine (CLAUDE.md)
Always import from
@trigger.dev/sdkwhen writing Trigger.dev tasks; never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
**/*.{test,spec}.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{test,spec}.{ts,tsx,js,jsx}: Write unit tests with Vitest, keep test files beside the files under test, and use descriptivedescribeanditblocks.
Avoid mocks or stubs in tests; when Redis or Postgres are needed, use the helpers from@internal/testcontainers.
Files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/friendlyId.test.ts
🧠 Learnings (12)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
📚 Learning: 2026-06-13T19:53:13.759Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3937
File: packages/trigger-sdk/skills/realtime-and-frontend/SKILL.md:258-260
Timestamp: 2026-06-13T19:53:13.759Z
Learning: When reviewing code that uses `trigger.dev/react-hooks`’s `useRealtimeRun`, preserve the call signature where the first argument is the full realtime handle object (not `handle.id`). This is intentional to maintain type-safety and is consistent with the official docs; do not suggest changing the first argument from the handle object to `handle.id`.
Applied to files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
📚 Learning: 2026-06-17T17:13:49.929Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3948
File: apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.bulk-actions.$bulkActionParam/route.tsx:48-62
Timestamp: 2026-06-17T17:13:49.929Z
Learning: In triggerdotdev/trigger.dev, within `dashboardLoader`/`dashboardAction` (or similar context resolver code) whenever you resolve an organization ID from an organization slug for RBAC/enterprise authorization scope, always read from the primary Prisma client (`prisma`), not `$replica`. Using `$replica` can hit replica-lag and cause the RBAC lookup/authorization to run without the correct org scope (bypassing intended role enforcement). Implement the slug→org lookup with `prisma.organization.findFirst(...)` (or equivalent primary-client query) and add an inline comment documenting why the primary client is required (replica lag could lead to unscoped RBAC checks).
Applied to files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
📚 Learning: 2026-06-23T13:04:21.413Z
Learnt from: carderne
Repo: triggerdotdev/trigger.dev PR: 4023
File: apps/webapp/app/services/upsertBranch.server.ts:14-18
Timestamp: 2026-06-23T13:04:21.413Z
Learning: In TypeScript, it’s valid to `import { type X }` and then use `typeof X` in a type-only position, e.g. `type Alias = z.infer<typeof X>`. The `type` modifier suppresses the runtime import, but the type checker still has the full exported type so `z.infer<typeof X>` can resolve correctly. In code reviews, don’t flag this as a TypeScript compile error as long as `typeof X` is used in a type context (e.g., with `z.infer`, `type` aliases, generics), not as a runtime value.
Applied to files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In this repo’s trigger.dev codebase, the “never mock — use testcontainers” guideline should only be applied to integration tests that talk to real external services (e.g., Redis, Postgres, S2). For unit tests that validate in-memory logic (e.g., deduplication/cache behavior in StandardRealtimeStreamsManager and similar module-boundary call counting), it is allowed to use Vitest mocks like `vi.fn()` and to stub/mock `ApiClient` objects to count calls or simulate in-process collaborators. Do not flag `vi.fn()`-based mocks as policy violations in these unit-test scenarios; reserve the rule for true external-service integration tests.
Applied to files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/friendlyId.test.ts
📚 Learning: 2026-05-18T14:40:02.173Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3658
File: packages/core/src/v3/realtimeStreams/manager.test.ts:1-147
Timestamp: 2026-05-18T14:40:02.173Z
Learning: In the triggerdotdev/trigger.dev repo, the policy “Never mock anything — use testcontainers instead” should only be enforced for integration tests that interact with real external services (e.g., Redis, Postgres) via actual infrastructure. For unit tests that exercise pure in-memory logic (e.g., cache semantics) it is OK to stub collaborators such as `ApiClient` using Vitest (`vi.fn()`) to assert call counts or control behavior. Do not flag `vi.fn()`-based `ApiClient` stubs in unit tests as violations of the testcontainers policy.
Applied to files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/friendlyId.test.ts
📚 Learning: 2026-06-04T18:16:35.386Z
Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 3836
File: apps/supervisor/src/backpressure/backpressureMonitor.ts:3-5
Timestamp: 2026-06-04T18:16:35.386Z
Learning: When reviewing TypeScript in this repo, apply the rule “prefer type aliases over interfaces” only to data/object shapes and union/intersection type modeling. If an interface is being used as a behavioral contract for collaborators to implement (e.g., method-shape interfaces that define required behavior, such as `BackpressureLogger` / `BackpressureSignalSource` in `apps/supervisor/src/backpressure/backpressureMonitor.ts`), keep it as an `interface` and do not flag it as a type-alias-vs-interface violation.
Applied to files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
📚 Learning: 2026-06-09T17:58:04.699Z
Learnt from: 0ski
Repo: triggerdotdev/trigger.dev PR: 3879
File: apps/webapp/app/models/vercelIntegration.server.ts:619-630
Timestamp: 2026-06-09T17:58:04.699Z
Learning: In this codebase, outbound raw `fetch` calls should typically rely on Node/undici’s default request timeout (about ~300s) rather than adding a per-call `AbortController` + `setTimeout` wrapper inside individual functions (e.g. in files like `apps/webapp/app/models/vercelIntegration.server.ts`). During code review, do not flag the absence of a per-call timeout on a single `fetch` as an issue; if per-call timeouts are needed, they should be implemented via a codebase-wide convention (e.g., a shared fetch wrapper or documented pattern) rather than ad-hoc per-function changes.
Applied to files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/index.tspackages/core/src/v3/isomorphic/friendlyId.test.tspackages/core/src/v3/isomorphic/runOpsResidency.tspackages/core/src/v3/isomorphic/friendlyId.ts
📚 Learning: 2026-06-16T09:19:47.637Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3960
File: apps/webapp/test/prismaInfrastructureErrorCapture.test.ts:0-0
Timestamp: 2026-06-16T09:19:47.637Z
Learning: In this repo’s Vitest setup, `vitest.config.ts` uses `globals: true`, so identifiers like `vi`, `describe`, `it`, and `expect` are available as globals in Vitest test files. During code review, do not flag missing `vi`/`describe`/`it`/`expect` imports as a runtime error or correctness issue when they’re used in `*.test.ts/tsx` or `*.spec.ts/tsx` files. Explicit imports are still preferred for consistency, but they’re not required for runtime behavior.
Applied to files:
packages/core/src/v3/isomorphic/runOpsResidency.test.tspackages/core/src/v3/isomorphic/friendlyId.test.ts
🔇 Additional comments (8)
packages/core/src/v3/isomorphic/runOpsResidency.ts (1)
1-59: LGTM!packages/core/src/v3/isomorphic/index.ts (1)
2-2: LGTM!packages/core/src/v3/isomorphic/runOpsResidency.test.ts (1)
1-62: LGTM!packages/core/src/v3/isomorphic/friendlyId.ts (2)
18-74: LGTM!
83-127: LGTM!packages/core/src/v3/isomorphic/friendlyId.test.ts (3)
1-51: LGTM!
92-128: LGTM!
53-61: 🎯 Functional CorrectnessNo issue; the base62 alphabet and byte layout match
friendlyId.ts.
Consumer packages (e.g. @internal/zod-worker) typecheck core's source under a target below ES2020, where BigInt literals (123n) raise TS2737. Use BigInt(...) calls, which those targets accept.
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
Fall back to node:crypto webcrypto when globalThis.crypto is unavailable (Node 18.20), share the ksuid length constant with the residency classifier, and tighten the ksuid/residency tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 participant
What
Foundation for the run-ops database split: an isomorphic id-shape residency classifier and the ksuid mint primitives, added to
@trigger.dev/coreunderv3/isomorphic.runOpsResidency.ts— classifies a run id by its shape: 25-char cuid →LEGACY, 27-char ksuid →NEW. Pure and environment-free (safe on both client and server).friendlyId.ts— ksuid mint primitives and id helpers.v3/isomorphic/index.ts.Why
This is the base of a stacked series implementing the run-ops DB split (routing run-execution data to a dedicated database by id-shape). Later PRs in the series consume this classifier and these primitives to route reads and writes across the two databases.
On its own this PR is purely additive — new isomorphic helpers with unit tests, no runtime wiring, and no behaviour change to existing code paths.
Tests
Unit tests for the classifier (
runOpsResidency.test.ts) and the id / mint primitives (friendlyId.test.ts).Notes
main; subsequent PRs in the series build on top of this one.@trigger.dev/corewill be added before this is marked ready for review.🤖 Generated with Claude Code