Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
f93edf5
chore: remove unused deps
carderne Aug 17, 2026
c68b40b
chore(build): remove unused version placeholder
carderne Aug 17, 2026
c8e4e6f
refactor(plugins): make assignment error code internal
carderne Aug 17, 2026
111248d
refactor(redis-worker): make round robin config internal
carderne Aug 17, 2026
28c8535
refactor(react-hooks): remove unused utility exports
carderne Aug 17, 2026
bcec53a
chore: add combined Knip check
carderne Aug 17, 2026
d1dfd92
refactor(testcontainers): remove unused container helpers
carderne Aug 17, 2026
7704e8f
refactor(emails): remove unused shared styles
carderne Aug 17, 2026
ceba247
refactor(schedule-engine): remove unused schedule APIs
carderne Aug 17, 2026
6535cb4
refactor(clickhouse): remove unused type exports
carderne Aug 17, 2026
c9a0284
refactor(observability-map): remove unused entry point
carderne Aug 17, 2026
609f884
refactor(observability-map): make report marker internal
carderne Aug 17, 2026
de64c34
refactor(observability-map): make context helper internal
carderne Aug 17, 2026
032a006
refactor(observability-map): make check status internal
carderne Aug 17, 2026
d8fb2e6
refactor(observability-map): make contribution type internal
carderne Aug 17, 2026
83e446f
refactor(observability-map): make mutation kind internal
carderne Aug 17, 2026
43dcafe
refactor(observability-map): make mutation result internal
carderne Aug 17, 2026
75ad1ee
refactor(webhook-engine): remove unused filter limit export
carderne Aug 17, 2026
1346029
refactor(webhook-engine): remove unused filter match export
carderne Aug 17, 2026
f401655
refactor(webhook-engine): make parent DDL internal
carderne Aug 17, 2026
2942c06
refactor(webhook-engine): make parent name internal
carderne Aug 17, 2026
56407b6
refactor(webhook-engine): make day bucket range internal
carderne Aug 17, 2026
101c7f7
refactor(webhook-engine): make partition listing internal
carderne Aug 17, 2026
c4731bb
refactor(webhook-engine): make signature parser internal
carderne Aug 17, 2026
c707d07
remove wrong knip command
carderne Aug 17, 2026
93c1503
refactor(supervisor): make runtime environment internal
carderne Aug 17, 2026
e7c0c7c
refactor(supervisor): remove unused request ID export
carderne Aug 17, 2026
2321ab5
refactor(supervisor): remove unused state factory export
carderne Aug 17, 2026
055b1c2
refactor(supervisor): remove unused wide event environment export
carderne Aug 17, 2026
4bc2751
refactor(supervisor): remove unused state options export
carderne Aug 17, 2026
5fec946
refactor(supervisor): remove unused wide event emitter export
carderne Aug 17, 2026
d885d07
refactor(supervisor): remove unused wide event message export
carderne Aug 17, 2026
3ee0a0b
refactor(supervisor): remove unused trace parser export
carderne Aug 17, 2026
6910d54
refactor(supervisor): remove unused event storage export
carderne Aug 17, 2026
ad4b7fa
refactor(supervisor): remove unused phase recorder export
carderne Aug 17, 2026
b127dd2
refactor(supervisor): remove unused phase timer export
carderne Aug 17, 2026
801525c
refactor(supervisor): remove unused phase options export
carderne Aug 17, 2026
69617f6
refactor(supervisor): remove unused lifecycle options export
carderne Aug 17, 2026
1b014eb
refactor(supervisor): remove unused error info re-export
carderne Aug 17, 2026
13d7698
refactor(supervisor): remove unused phase record export
carderne Aug 17, 2026
f57ca89
refactor(supervisor): remove unused auth outcome type
carderne Aug 17, 2026
f87613c
refactor(supervisor): make backpressure logger internal
carderne Aug 17, 2026
22515a9
refactor(supervisor): make wide event error type internal
carderne Aug 17, 2026
abbf8e9
refactor(run-engine): remove unused queue error
carderne Aug 17, 2026
8f4a33d
test(run-engine): remove unused execution state helper
carderne Aug 17, 2026
5ca6526
test(run-engine): remove unused engine fixture
carderne Aug 17, 2026
0e407eb
refactor(run-engine): make worker task selection internal
carderne Aug 17, 2026
4de1600
refactor(run-engine): make task queue selection internal
carderne Aug 17, 2026
cb7fbe9
refactor(run-engine): make deployment selection internal
carderne Aug 17, 2026
7671ed0
refactor(run-engine): make worker version filter internal
carderne Aug 17, 2026
a18814c
refactor(run-engine): remove unused no-op queue strategy
carderne Aug 17, 2026
82f0e4f
refactor(run-engine): make queue strategy biases internal
carderne Aug 17, 2026
44df1b3
test(run-engine): make output generator internal
carderne Aug 17, 2026
7ca8a00
test(run-engine): make waitpoint helper internal
carderne Aug 17, 2026
ef0626c
test(run-engine): make checkpoint helper internal
carderne Aug 17, 2026
864a2d9
refactor(run-engine): remove unused retry priority offset
carderne Aug 17, 2026
cc82db4
refactor(run-engine): remove unused delayed requeue threshold
carderne Aug 17, 2026
756a386
refactor(run-engine): remove unused scheduled requeue threshold
carderne Aug 17, 2026
83d5e9a
refactor(run-engine): make git metadata parser internal
carderne Aug 17, 2026
d730e73
refactor(run-engine): remove unused TTL worker catalog
carderne Aug 17, 2026
98b3c5a
refactor(run-engine): make sweeper callback internal
carderne Aug 17, 2026
c9c3aa6
refactor(run-engine): make guard decision internal
carderne Aug 17, 2026
9eb0b88
refactor(run-engine): remove unused debounce data type
carderne Aug 17, 2026
7dd9a17
refactor(trigger-sdk): remove unused exports
carderne Aug 17, 2026
62dcc56
refactor(dashboard-agent): remove unused exports
carderne Aug 17, 2026
1a604b0
refactor(core): remove unused code exports
carderne Aug 17, 2026
229ef84
refactor(tsql): remove unused exports
carderne Aug 17, 2026
df601c6
refactor(otlp-importer): remove unused code
carderne Aug 17, 2026
4e3e11e
refactor(cli): remove unused code
carderne Aug 17, 2026
ca79aa9
refactor(webapp): remove unused code
carderne Aug 17, 2026
072e735
ci: check unused code with knip
carderne Aug 17, 2026
fd32cff
chore: remove redundant knip entries
carderne Aug 17, 2026
3f2474d
remove knip:deps
carderne Aug 17, 2026
9cf072d
format
carderne Aug 18, 2026
15b49b0
lint fixes
carderne Aug 18, 2026
ef19513
fix more lints
carderne Aug 18, 2026
34b2dcb
test(webapp): restore PAT action type guard
carderne Aug 18, 2026
e8b9f37
fix(dashboard-agent): restore scheduled maintenance tasks
carderne Aug 18, 2026
e10fa6f
fix: restore build and test fixtures
carderne Aug 18, 2026
e0de765
fix: preserve package entry points and checks
carderne Aug 18, 2026
78affee
test(observability-map): update sensitive symbols
carderne Aug 18, 2026
1984009
test: update cleanup contracts
carderne Aug 18, 2026
57da81d
fix(webapp): remove orphaned deprecation note
carderne Aug 18, 2026
5ca144f
cache knip, add to agents.md
carderne Aug 18, 2026
6968e62
fix contributing.md
carderne Aug 18, 2026
63a617f
update agents.md
carderne Aug 18, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 3 additions & 0 deletions .github/workflows/code-quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,6 @@ jobs:

- name: 🔎 Lint
run: pnpm exec oxlint .

- name: ✂️ Check unused code and dependencies
run: pnpm run knip
Comment thread
carderne marked this conversation as resolved.
12 changes: 12 additions & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,18 @@ pnpm run lint:fix # oxlint — auto-fixes lint violations
pnpm run lint # oxlint — check only (no fixes)
```

### Dead code

We use knip to control unused dependencies and code. It is enforced by CI `code-quality`.

Scan your code before pushing with:

```bash
pnpm run knip
```

If there are false positives, edit ./knip.json so that it passes.

### Imports

**Prefer static imports over dynamic imports.** Only use dynamic `import()` when:
Expand Down
7 changes: 4 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -238,10 +238,11 @@ This never affects correctness — CI enforces the same checks on every PR; the
1. **Always open your PR in draft status first.** Do not mark it as "Ready for Review" until the steps below are complete.
2. **Run format and lint locally before pushing:**
```bash
pnpm run format # auto-fixes formatting (oxfmt)
pnpm run lint:fix # auto-fixes lint violations (oxlint)
pnpm run format
pnpm run lint
pnpm run knip
```
Both are enforced by CI — the `code-quality` check will fail if either produces a diff or errors.
These are enforced by CI — the `code-quality` check will fail if either produces a diff or errors.
3. **Address all CodeRabbit code review comments.** Our CI runs an automated code review via CodeRabbit. Go through each comment and either fix the issue or resolve it with a comment explaining why no change is needed.
4. **Wait for all CI checks to pass.** Do not mark the PR as "Ready for Review" until every check is green.
5. **Then mark the PR as "Ready for Review"** so a maintainer can take a look.
Expand Down
2 changes: 1 addition & 1 deletion apps/supervisor/src/backpressure/backpressureMonitor.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { BackpressureMetrics } from "./backpressureMetrics.js";

export interface BackpressureLogger {
interface BackpressureLogger {
info(message: string, meta?: Record<string, unknown>): void;
error(message: string, meta?: Record<string, unknown>): void;
}
Expand Down
2 changes: 1 addition & 1 deletion apps/supervisor/src/clients/kubernetes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { Informer, KubernetesObject, ListPromise } from "@kubernetes/client
import { assertExhaustive } from "@trigger.dev/core/utils";
import { SimpleStructuredLogger } from "@trigger.dev/core/v3/utils/structuredLogger";

export const RUNTIME_ENV = process.env.KUBERNETES_PORT ? "kubernetes" : "local";
const RUNTIME_ENV = process.env.KUBERNETES_PORT ? "kubernetes" : "local";

const logger = new SimpleStructuredLogger("kubernetes-client");

Expand Down
10 changes: 3 additions & 7 deletions apps/supervisor/src/wideEvents/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,14 @@
* Off by default behind a kill switch - the dispatch hotpath runs at high
* QPS, so logging pressure must be cleanly removable.
*/
export { type Env, isValidRequestId, newState, type NewStateOptions } from "./new.js";
export { emit, EmitMessage } from "./emit.js";
export { parseTraceId } from "./traceparent.js";
export { fromContext, wideEventStorage } from "./context.js";
export { type PhaseOpt, recordPhase, recordPhaseSince, timePhase } from "./record.js";
export { fromContext } from "./context.js";
export { recordPhaseSince } from "./record.js";
export {
emitOneShot,
runWideEvent,
setExtra,
setMeta,
type WideEventLifecycleOptions,
type WideEventOptions,
} from "./middleware.js";
export type { ErrorInfo, PhaseRecord, State } from "./state.js";
export type { State } from "./state.js";
export { encodeBaggage } from "./baggage.js";
2 changes: 1 addition & 1 deletion apps/supervisor/src/wideEvents/state.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export type PhaseRecord = {
};

/** Top-level error summary for a failed operation. */
export type ErrorInfo = {
type ErrorInfo = {
code: string;
message: string;
/** Coarse classification - "client" | "upstream" | "internal" | "timeout". */
Expand Down
1 change: 0 additions & 1 deletion apps/supervisor/src/workloadToken.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ const mintCounter = new Counter({
});

export type WorkloadAuthTransport = "http" | "ws";
export type WorkloadAuthOutcome = "jwt_valid" | "jwt_invalid" | "legacy_bare" | "token_absent";

const verifyCounter = new Counter({
name: "workload_auth_verify_total",
Expand Down
21 changes: 0 additions & 21 deletions apps/webapp/app/assets/logos/ATAndTLogo.tsx

This file was deleted.

57 changes: 0 additions & 57 deletions apps/webapp/app/assets/logos/AstroLogo.tsx

This file was deleted.

Loading
Loading