-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: enforce no unused deps or code in ci #4654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
f93edf5
chore: remove unused deps
carderne c68b40b
chore(build): remove unused version placeholder
carderne c8e4e6f
refactor(plugins): make assignment error code internal
carderne 111248d
refactor(redis-worker): make round robin config internal
carderne 28c8535
refactor(react-hooks): remove unused utility exports
carderne bcec53a
chore: add combined Knip check
carderne d1dfd92
refactor(testcontainers): remove unused container helpers
carderne 7704e8f
refactor(emails): remove unused shared styles
carderne ceba247
refactor(schedule-engine): remove unused schedule APIs
carderne 6535cb4
refactor(clickhouse): remove unused type exports
carderne c9a0284
refactor(observability-map): remove unused entry point
carderne 609f884
refactor(observability-map): make report marker internal
carderne de64c34
refactor(observability-map): make context helper internal
carderne 032a006
refactor(observability-map): make check status internal
carderne d8fb2e6
refactor(observability-map): make contribution type internal
carderne 83e446f
refactor(observability-map): make mutation kind internal
carderne 43dcafe
refactor(observability-map): make mutation result internal
carderne 75ad1ee
refactor(webhook-engine): remove unused filter limit export
carderne 1346029
refactor(webhook-engine): remove unused filter match export
carderne f401655
refactor(webhook-engine): make parent DDL internal
carderne 2942c06
refactor(webhook-engine): make parent name internal
carderne 56407b6
refactor(webhook-engine): make day bucket range internal
carderne 101c7f7
refactor(webhook-engine): make partition listing internal
carderne c4731bb
refactor(webhook-engine): make signature parser internal
carderne c707d07
remove wrong knip command
carderne 93c1503
refactor(supervisor): make runtime environment internal
carderne e7c0c7c
refactor(supervisor): remove unused request ID export
carderne 2321ab5
refactor(supervisor): remove unused state factory export
carderne 055b1c2
refactor(supervisor): remove unused wide event environment export
carderne 4bc2751
refactor(supervisor): remove unused state options export
carderne 5fec946
refactor(supervisor): remove unused wide event emitter export
carderne d885d07
refactor(supervisor): remove unused wide event message export
carderne 3ee0a0b
refactor(supervisor): remove unused trace parser export
carderne 6910d54
refactor(supervisor): remove unused event storage export
carderne ad4b7fa
refactor(supervisor): remove unused phase recorder export
carderne b127dd2
refactor(supervisor): remove unused phase timer export
carderne 801525c
refactor(supervisor): remove unused phase options export
carderne 69617f6
refactor(supervisor): remove unused lifecycle options export
carderne 1b014eb
refactor(supervisor): remove unused error info re-export
carderne 13d7698
refactor(supervisor): remove unused phase record export
carderne f57ca89
refactor(supervisor): remove unused auth outcome type
carderne f87613c
refactor(supervisor): make backpressure logger internal
carderne 22515a9
refactor(supervisor): make wide event error type internal
carderne abbf8e9
refactor(run-engine): remove unused queue error
carderne 8f4a33d
test(run-engine): remove unused execution state helper
carderne 5ca6526
test(run-engine): remove unused engine fixture
carderne 0e407eb
refactor(run-engine): make worker task selection internal
carderne 4de1600
refactor(run-engine): make task queue selection internal
carderne cb7fbe9
refactor(run-engine): make deployment selection internal
carderne 7671ed0
refactor(run-engine): make worker version filter internal
carderne a18814c
refactor(run-engine): remove unused no-op queue strategy
carderne 82f0e4f
refactor(run-engine): make queue strategy biases internal
carderne 44df1b3
test(run-engine): make output generator internal
carderne 7ca8a00
test(run-engine): make waitpoint helper internal
carderne ef0626c
test(run-engine): make checkpoint helper internal
carderne 864a2d9
refactor(run-engine): remove unused retry priority offset
carderne cc82db4
refactor(run-engine): remove unused delayed requeue threshold
carderne 756a386
refactor(run-engine): remove unused scheduled requeue threshold
carderne 83d5e9a
refactor(run-engine): make git metadata parser internal
carderne d730e73
refactor(run-engine): remove unused TTL worker catalog
carderne 98b3c5a
refactor(run-engine): make sweeper callback internal
carderne c9c3aa6
refactor(run-engine): make guard decision internal
carderne 9eb0b88
refactor(run-engine): remove unused debounce data type
carderne 7dd9a17
refactor(trigger-sdk): remove unused exports
carderne 62dcc56
refactor(dashboard-agent): remove unused exports
carderne 1a604b0
refactor(core): remove unused code exports
carderne 229ef84
refactor(tsql): remove unused exports
carderne df601c6
refactor(otlp-importer): remove unused code
carderne 4e3e11e
refactor(cli): remove unused code
carderne ca79aa9
refactor(webapp): remove unused code
carderne 072e735
ci: check unused code with knip
carderne fd32cff
chore: remove redundant knip entries
carderne 3f2474d
remove knip:deps
carderne 9cf072d
format
carderne 15b49b0
lint fixes
carderne ef19513
fix more lints
carderne 34b2dcb
test(webapp): restore PAT action type guard
carderne e8b9f37
fix(dashboard-agent): restore scheduled maintenance tasks
carderne e10fa6f
fix: restore build and test fixtures
carderne e0de765
fix: preserve package entry points and checks
carderne 78affee
test(observability-map): update sensitive symbols
carderne 1984009
test: update cleanup contracts
carderne 57da81d
fix(webapp): remove orphaned deprecation note
carderne 5ca144f
cache knip, add to agents.md
carderne 6968e62
fix contributing.md
carderne 63a617f
update agents.md
carderne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,3 +36,6 @@ jobs: | |
|
|
||
| - name: 🔎 Lint | ||
| run: pnpm exec oxlint . | ||
|
|
||
| - name: ✂️ Check unused code and dependencies | ||
| run: pnpm run knip | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.