Draft
Conversation
Contributor
Author
|
The bug mentioned in trussed-dev/littlefs2#33 does not affect this PR anyway because the current behaviour of iteration is to consider any filesystem error as the end of the iteration, which means the bug does not change observed behaviour. |
Member
|
In favor of this, needs some conflict fixing. |
sosthene-nitrokey
force-pushed
the
iteration-optimisation
branch
from
6f86944 to
997720f
Compare
sosthene-nitrokey
force-pushed
the
iteration-optimisation
branch
from
994c67f to
f48ccef
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is built on top of #104 and #96, and trussed-dev/littlefs2#33
This PR:
Uses the apis added to trussed-dev/littlefs2#33 to improve the skipping that happens each time in$O(n)$ (with n being the number of files in the directory, but it should be much faster.
read_dir(_files)_next(). I think the operation is likely stillIt also exposes$O(n^2)$ operation
read_dir(_files)_nthsyscalls that make it possible to resume iteration at a certain point without having to iterate n time withread_dir(_files)_next, which is a