fix(olm): correct TrustedExecutionCluster example in CSV template#212
Merged
alicefr merged 1 commit intotrusted-execution-clusters:mainfrom Mar 11, 2026
Merged
Conversation
Contributor
Author
|
depends on #211 |
yalzhang
force-pushed
the
update_alm
branch
2 times, most recently
from
72cb0b6 to
123fc96
Compare
yalzhang
force-pushed
the
update_alm
branch
2 times, most recently
from
49beaab to
601ac33
Compare
yalzhang
force-pushed
the
update_alm
branch
3 times, most recently
from
2a2c00b to
f9c6701
Compare
Add one more simple version of TrustedExecutionCluster example in CSV template alm-examples section. And fix the format. The alm-examples section had an incorrect format where the port was included in publicTrusteeAddr. This fix separates the address from the ports, adding registerServerPort and trusteeKbsPort as separate fields to match the actual CR specification and working examples. Update the README.md file to reflect the change. Update the annotations to be in 'dev-preview' channel. Update the tag in the csv template to be 0.2.0. Signed-off-by: Yalan Zhang <yalzhang@redhat.com>
Contributor
Author
|
Have tested the different format of trustedexecutioncluster CR on Azure and kind, and updated in the CSV accordingly. |
alicefr
approved these changes
Mar 11, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alicefr, yalzhang The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alm-examples section had an incorrect format where the port was included in publicTrusteeAddr. This fix separates the address from the ports, adding registerServerPort and trusteeKbsPort as separate fields to match the actual CR specification and working examples.