Skip to content

Fix out-of-bounds write for causal ancestral alleles #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeromekelleher merged 4 commits into from
Sep 2, 2026
Merged

Fix out-of-bounds write for causal ancestral alleles #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f74ace4
Fix out-of-bounds write for causal ancestral alleles
jeromekelleher Sep 2, 2026
d46e3cf
Test the jit kernels over a range of tree topologies
jeromekelleher Sep 2, 2026
63c33d0
Fixup refs in the CHANGELOG
jeromekelleher Sep 2, 2026
2ef7834
Bump docs build version to fix error
jeromekelleher Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ permissions:

jobs:
Docs:
uses: tskit-dev/.github/.github/workflows/docs.yml@v19
uses: tskit-dev/.github/.github/workflows/docs.yml@v21
14 changes: 10 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,20 @@ In development

- Extended `genetic_value` with `level="individual"` (default), `level="node"`,
and `level="edge"` to return genetic values for the corresponding entities.
{pr}`155`
- Added `edge_effect` to compute introduced effects on edges {pr}`155`
{pr}`189`
- Added `edge_effect` to compute introduced effects on edges {pr}`189`

### Documentation

- Added a worked example relating causal-allele effects,
edge effects, and edge, node, and individual genetic values {pr}`155`
- Clarified that tstrait currently uses a site-mode effect model {pr}`155`
edge effects, and edge, node, and individual genetic values {pr}`189`
- Clarified that tstrait currently uses a site-mode effect model {pr}`189`

### Fix

- Fix an out-of-bounds write in the node traversal when the causal allele is
the ancestral allele, in which case the virtual root is a causal node
{pr}`192`, {issue}`191`.

## [0.1.2] - 2026-03-03

Expand Down
Loading