Improve nob__proc_wait_async API#108
Closed
TheZouave007 wants to merge 2 commits intotsoding:mainfrom
Closed
Conversation
Member
|
Closed due to "No changes to the public API" policy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API of
nob__proc_wait_asyncis improved by moving out sleeps into a different function. This supports checking all of the handles in aNob_Procsstructure without any delay.The previous implementation will take 14 milliseconds to check to the 15th procedure in the
Nob_Procsstruct because each check would spend a millisecond either sleeping or timing out. By decoupling checking if a process is finished from sleeping, the API is improved and control is gained.This also creates the function
nob_sleep_nanos.