Skip to content

Update phone_number.py#912

Open
gamero3alberto wants to merge 1 commit intotwilio:mainfrom
gamero3alberto:main
Open

Update phone_number.py#912
gamero3alberto wants to merge 1 commit intotwilio:mainfrom
gamero3alberto:main

Conversation

@gamero3alberto
Copy link

Correction of the type of variable line_type_intelligence, in response to issue #883

Fixes

The variable line_type_intelligence is typed as an Optional[str], but according to the API documentation, it receives a JSON with the following parameters: mobileCountryCode, mobileNetworkCode, carrierName, type, errorCode. These values must be interpreted and stored in the variable line_type_intelligence, so it must necessarily be a dictionary with a key, a string, and a value, an object. Optional[Dict[str, object]]

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

The type of line_type_intelligence is wrong, as it recieves a JSON with plenty of parameters. So it has to be a dictionary of str-object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant