Open
Conversation
The type of line_type_intelligence is wrong, as it recieves a JSON with plenty of parameters. So it has to be a dictionary of str-object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction of the type of variable line_type_intelligence, in response to issue #883
Fixes
The variable line_type_intelligence is typed as an Optional[str], but according to the API documentation, it receives a JSON with the following parameters: mobileCountryCode, mobileNetworkCode, carrierName, type, errorCode. These values must be interpreted and stored in the variable line_type_intelligence, so it must necessarily be a dictionary with a key, a string, and a value, an object. Optional[Dict[str, object]]
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.