Overlay Function#16
Conversation
|
Its working on my end. Let me know if there are any issues. I might've pushed the commit wrong! |
|
|
||
| fun canUseShizuku(): Boolean { | ||
| return ShizukuShell.isAvailable() | ||
| } |
There was a problem hiding this comment.
Root is also available, so it should be considered just as well. If you do it via RootBeer, remember to put it into a coroutine, because it's pretty resource-heavy as I've already learned
| .padding(horizontal = 16.dp) | ||
| .pointerInput(Unit) { | ||
| detectTapGestures { | ||
| // Consume taps inside the overlay card so only outside taps close it. |
There was a problem hiding this comment.
I don't believe it's necessary, if you remove the whole .pointerInput block, it should consume taps just as well (but I could be wrong here, so double-check)
|
|
||
| Text( | ||
| text = if (hasPrivileges) { | ||
| "Tap to open • Swipe up/down to kill • Scroll left/right" |
There was a problem hiding this comment.
Extract all strings to strings.xml to facilitate localizing
|
|
||
| private const val DEFAULT_REFRESH_SECONDS = 10 | ||
|
|
||
| fun getRefreshSeconds(context: Context): Int { |
There was a problem hiding this comment.
Better to inject SharedPreferences into a manager, just like it's done in SettingsHolder
|
I see your commit alright, but it appears you made your changes on top of an older commit, reverting many changes in the process :/ Please try to revert all changes this PR introduces to files that aren't relevant to the overlay functionality, as I also see you made changes to e.g. how Shizuku is managed (keep it within |
2 participants
Added overlay function