Accept names that start with a keyword - #900
Merged
Merged
Conversation
The fragment-name parser rejected any name that starts with "on". The enum-value parser rejected any name that starts with "true", "false" or "null". Both lookaheads had no word-boundary check. Changes: - `FragmentName` and `EnumValue` now reject only the exact keyword. - `BooleanValue` requires a word boundary after "true" or "false", and backtracks so that `trueStory` can parse as an enum value. - `NullValue` backtracks for the same reason. - `InlineFragment` backtracks its type condition, so that `...onFoo` falls through to the fragment-spread branch.
hugo-vrijswijk
force-pushed
the
fix/f12-keyword-prefix-names
branch
from
August 20, 2026 10:31
ba37862 to
4bb9665
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fragment-name parser rejected any name that starts with "on". The enum-value parser rejected any name that starts with "true", "false" or "null". Both lookaheads had no word-boundary check.
Changes:
FragmentNameandEnumValuenow reject only the exact keyword.BooleanValuerequires a word boundary after "true" or "false", and backtracks so thattrueStorycan parse as an enum value.NullValuebacktracks for the same reason.InlineFragmentbacktracks its type condition, so that...onFoofalls through to the fragment-spread branch.