Accept a comment at the end of a file - #901
Merged
Merged
Conversation
phdoerfler
requested changes
Aug 20, 2026
phdoerfler
left a comment
phdoerfler
left a comment
Contributor
There was a problem hiding this comment.
Aside from the comment-only test it looks good. The GraphQL grammar ends a comment at the end of the input as well as at a LineTerminator, so this matches the spec.
The comment parser required a line terminator after the comment text. A comment at the end of the file has none, so the whole document failed to parse.
The terminator is now `charIn('\n', '\r') | Parser.end`.
hugo-vrijswijk
force-pushed
the
fix/f13-trailing-comment
branch
from
August 20, 2026 08:03
41fdbc7 to
0b1999b
Compare
phdoerfler
approved these changes
Aug 20, 2026
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment parser required a line terminator after the comment text. A comment at the end of the file has none, so the whole document failed to parse.
The terminator is now
charIn('\n', '\r') | Parser.end.