Seed rules whose own source files changed at distance 0#119
Merged
Conversation
A rule whose srcs include a changed source file is now promoted to a BFS seed (distance 0) instead of appearing at distance 1 behind the source-file node. This makes distance == 0 mean "this target's own inputs changed" rather than requiring consumers to look through the source-file indirection. The fix adds hasChangedSourceFileDep(), called during Pass 2 seed classification, which checks whether any of a rule's direct dependencies is both changed and a source file. Behavior change: downstream targets of such rules shift one hop closer in the BFS, so a given max_distance will include a slightly larger set. This is more correct since the semantic seed is the rule, not the file. Test Plan: - Updated TestCompareTargetGraphs_SourceFileDirectAndPropagation and TestCompareTargetGraphs_HashOnlyChangePropagatesViaBFS to expect distance 0 for rules owning changed source files. - Added TestCompareTargetGraphs_SiblingRuleNotPromotedToSeed: verifies a rule depending on a sibling rule (not its own source file) stays at distance 1.
|
|
yushan8
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rule whose srcs include a changed source file is now promoted to a BFS seed (distance 0) instead of appearing at distance 1 behind the source-file node. This makes distance == 0 mean "this target's own inputs changed" rather than requiring consumers to look through the source-file indirection.
The fix adds hasChangedSourceFileDep(), called during Pass 2 seed classification, which checks whether any of a rule's direct dependencies is both changed and a source file.
Behavior change: downstream targets of such rules shift one hop closer in the BFS, so a given max_distance will include a slightly larger set. This is more correct since the semantic seed is the rule, not the file.
Test Plan:
Unit tested
Issue