Repository navigation
sort: fix sort ordering check and multi-file merge on wasi - #13688
Conversation
362b58c to
e7e30d4
Compare
Merging this PR will not alter performance1 warning, 1 note
Comparing Footnotes
|
bd72c05 to
62496f4
Compare
62496f4 to
90923fb
Compare
|
GNU testsuite comparison: |
90923fb to
4f35ec1
Compare
|
Priority given to #13806. I have put this one to draft and will close it as soon as the necessary changes have been merged to main. |
|
@eduardomourar thanks for this great behavior ! :) |
84c57eb to
5488558
Compare
|
I have to mark this PR back as ready because it is still required. |
bb8a945 to
001176e
Compare
001176e to
bf2a1b7
Compare
bf2a1b7 to
d6639d7
Compare
|
Binary size comparison: |
d6639d7 to
9e15aeb
Compare
9e15aeb to
bb91f38
Compare
bb91f38 to
2c8ea97
Compare
sort -cdoes not work on WASI. The check uses a background reader thread, and WASI has no threads.Multi-file input also fails on WASI. The external sort concatenates the files without a separator, so the last line of one file joins the first line of the next.
test_sort::sort_multipleandtest_sort::test_checkin the WASI CI job.