Repository navigation
stty: extend cfg for discipline - #15605
Conversation
|
Has compilation been checked locally on all affected targets? |
|
No. I'll restrict this PR to android if I need to much care for minor targets missing from CI. |
15b72ea to
5526c78
Compare
I don't think it's too much an imposition to ask if the package can be compiled on affected targets. For the record, the changes compile successfully on fuchsia and haiku $ RUSTC_BOOTSTRAP=1 cargo clippy -q -Zbuild-std=std \
-p uu_stty --lib --all-features \
--target x86_64-unknown-fuchsia \
--target x86_64-unknown-haiku |
This comment was marked as outdated.
This comment was marked as outdated.
|
The changes seemed reasonable, I don't understand why the PR was closed. |
5526c78 to
0d2e1a6
Compare
|
But haiku will be broken by |
|
These changes compile on haiku, so there’s no issue for now. If a future change breaks haiku and is otherwise justified, support for that target can be disabled via |
|
coreutils/src/uu/stty/src/stty.rs Lines 953 to 957 in 744e299 |
| target_os = "haiku", | ||
| target_os = "linux", | ||
| target_os = "redox" | ||
| ))] |
There was a problem hiding this comment.
could you please use the same cfg list in apply_special_setting for line N? it is still linux/android only there (and the comment still says nix)
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Thanks for your PR |
Android can be tested on the CI. https://docs.rs/rustix/latest/rustix/termios/struct.Termios.html#structfield.line_discipline