Skip to content

dd: support wasi without threads or descriptor duplication - #16094

Open
eduardomourar wants to merge 1 commit into
uutils:mainfrom
eduardomourar:feat/wasi-dd
Open

eduardomourar wants to merge 1 commit into
uutils:mainfrom
eduardomourar:feat/wasi-dd

Conversation

@eduardomourar

@eduardomourar eduardomourar commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

WASI Preview 2 has no threads. The progress reporter prints inline and the alarm polls the clock. dd reads stdin through a File, as on Unix. dd takes ownership of the stdout descriptor, because WASI cannot duplicate descriptors. An empty path fails with ENOENT, because WASI resolves it to the preopened directory.

Ignore the dd tests that the WASI sandbox cannot run.

Related to #16599.

@sylvestre

Copy link
Copy Markdown
Contributor

clippy is sad :), and a bunch of jobs are failing

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/tail/follow-name is no longer failing!
Congrats! The gnu test tests/tail/pid-pipe is no longer failing!

@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 155.50 MB (+116 KB, +0.07%)

Significant per-binary changes:
  env     1.20 MB ->    1.28 MB  (+80 KB, +6.51%)

@sylvestre

Copy link
Copy Markdown
Contributor

thanks for working on this!
clippy and several CI jobs are still failing. Also, the WASI progress reporter duplicates gen_prog_updater (see the inline comments).

@eduardomourar

Copy link
Copy Markdown
Contributor Author

The linting problem is not coming from my changes. By the way, I don't see any inline comments on this PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants