Skip to content

build: fix used_underscore_binding clippy lint - #16402

Merged
cakebaker merged 1 commit into
uutils:mainfrom
xtqqczze:lint/used_underscore_binding
Nov 13, 2026
Merged

cakebaker merged 1 commit into
uutils:mainfrom
xtqqczze:lint/used_underscore_binding

Conversation

@xtqqczze

Copy link
Copy Markdown
Collaborator

No description provided.

@xtqqczze
xtqqczze marked this pull request as ready for review November 13, 2026 02:13
Comment thread src/uu/stty/src/stty.rs
{
_termios.line_discipline = *n;
termios.line_discipline = *n;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}
let _ = termios;

This currentlly 2 targets only, but it wil be verbose soon. I don't want to have 2 large cfg blocks.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)

@oech3

oech3 commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

@sylvestre This is required to fix CI.

@cakebaker
cakebaker merged commit 12e107f into uutils:main Nov 13, 2026
101 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

@xtqqczze
xtqqczze deleted the lint/used_underscore_binding branch November 13, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants