Skip to content

rewrite check-libc-interposition.sh in Rust for cargo test - #16403

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:fake-rust
Open

oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:fake-rust

Conversation

@oech3

@oech3 oech3 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

part of #16404

Comment thread tests/by-util/test_chmod.rs Resolved
Comment thread tests/by-util/test_chmod.rs Resolved
@oech3
oech3 force-pushed the fake-rust branch 2 times, most recently from ad4b23c to d7e3a4e Compare November 13, 2026 09:38
@oech3
oech3 requested a review from RenjiSann November 13, 2026 12:49
@RenjiSann

Copy link
Copy Markdown
Collaborator

Wanted to rebase, but I missclicked and did a merge commit instead, sorry 😅

@oech3

oech3 commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

Squash merge is possible.

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)

@sylvestre

Copy link
Copy Markdown
Contributor

The chmod test no longer covers what the script checked: it runs chmod on a plain file, so the recursive directory path from #14028 isn't tested anymore (details inline).
Please also update the comment at util/check-common.sh:4, which still lists check-libc-interposition.sh.

Comment thread tests/by-util/test_chmod.rs Resolved
Comment thread tests/uutests/src/lib/util.rs Resolved
Comment thread tests/by-util/test_chown.rs Resolved
Comment thread tests/by-util/test_chmod.rs Resolved
Comment thread tests/by-util/test_chmod.rs Resolved
Comment thread tests/by-util/test_chown.rs Resolved
Comment thread .github/workflows/CICD.yml Resolved
@oech3
oech3 force-pushed the fake-rust branch 4 times, most recently from 6b85249 to 302dad7 Compare November 14, 2026 03:24
@oech3
oech3 requested a review from sylvestre November 14, 2026 04:25
Comment thread util/check-common.sh Resolved
@oech3
oech3 force-pushed the fake-rust branch 2 times, most recently from 2fb51c3 to beacc19 Compare November 19, 2026 14:44

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants