Skip to content

android.yml: speed up CI (about 3 min) - #16675

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:android-fast-ci
Open

oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:android-fast-ci

Conversation

@oech3

@oech3 oech3 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Closes #16669 Closes #16619 Closes #16663

Comment thread .github/workflows/android.yml Resolved
Comment thread .github/workflows/android.yml Resolved
Comment thread .cargo/config.toml Resolved
Comment thread .github/workflows/android.yml Resolved
Comment thread .github/workflows/android.yml Resolved
Comment thread .github/workflows/android.yml Resolved
@oech3
oech3 force-pushed the android-fast-ci branch 4 times, most recently from 236d89a to f4323f8 Compare November 18, 2026 14:07
@oech3

oech3 commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

*ftl was fixed, but many tests are failing.

@oech3
oech3 marked this pull request as draft November 18, 2026 14:10
@oech3

This comment was marked as resolved.

@oech3
oech3 force-pushed the android-fast-ci branch 2 times, most recently from cf9ba27 to a6f3000 Compare November 18, 2026 15:27
@oech3
oech3 marked this pull request as ready for review November 18, 2026 15:28
@oech3

oech3 commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

I was needed to ignore some tests. Some tests might cross-build specific. But I think that cross-build for Android is important more than native build for most developers and better to catch those issues more that passing at native build.

Comment thread tests/by-util/test_od.rs Resolved
Comment thread tests/by-util/test_ls.rs Resolved
Comment thread tests/by-util/test_cp.rs Outdated
#[uutests::wasi_ignore(NoPermissionBits)]
#[test]
#[cfg(not(windows))]
#[cfg_attr(target_os = "android", ignore = "sandbox?")]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"sandbox?" isn't a reason. Please find the real one, or move the ignores to a separate PR

Comment thread .github/workflows/android.yml Resolved
Comment thread .github/workflows/android.yml Resolved
Comment thread .github/workflows/android.yml Outdated
[ .[] | select(.executable != null) | .executable | select(test("/coreutils$") | not) ]
| unique
| .[]
' | sed 's#^.*$#adb push & /data/local/tmp/tester\nadb shell "cd /data/local/tmp \&\& UUTESTS_BINARY_PATH=/data/local/tmp/coreutils /data/local/tmp/tester"#' > tests.sh

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generating shell with sed is hard to read. Could tests.sh be a simple loop over the list?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. script: section rejected any loop syntax.

Comment thread .github/workflows/android.yml Resolved
@oech3
oech3 force-pushed the android-fast-ci branch 2 times, most recently from 6c90098 to 7f948fa Compare November 19, 2026 00:07
@github-actions

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 155.48 MB (+100 KB, +0.06%)

Significant per-binary changes:
  env     1.20 MB ->    1.28 MB  (+80 KB, +6.51%)

@oech3
oech3 force-pushed the android-fast-ci branch 9 times, most recently from 193a835 to b769eb0 Compare November 19, 2026 03:27
@oech3

oech3 commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

I updated ignored comment, or adjusted tests except for od.

@codspeed

codspeed Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 3.02%

1 warning, 1 note

⚠️ 38 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ This run is excluded from the branch history

This commit was force-pushed, so this run no longer appears in the branch's performance history.

❌ 1 regressed benchmark
✅ 62 untouched benchmarks
⏩ 420 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ dd_copy_with_skip 4.8 ms 4.9 ms -3.02%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:android-fast-ci (b769eb0) with main (293a724)2

Open in CodSpeed

Footnotes

  1. 420 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (91f89c4) during the generation of this report, so 293a724 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/tail/follow-name is no longer failing!
Congrats! The gnu test tests/tail/pid-pipe is no longer failing!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

android.yml: build binaries on Ubuntu, not at Android for speed Drop legacy API from Android CI

2 participants