Repository navigation
Conversation
236d89a to
f4323f8
Compare
|
*ftl was fixed, but many tests are failing. |
f4323f8 to
11f5dc6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cf9ba27 to
a6f3000
Compare
|
I was needed to ignore some tests. Some tests might cross-build specific. But I think that cross-build for Android is important more than native build for most developers and better to catch those issues more that passing at native build. |
| #[uutests::wasi_ignore(NoPermissionBits)] | ||
| #[test] | ||
| #[cfg(not(windows))] | ||
| #[cfg_attr(target_os = "android", ignore = "sandbox?")] |
There was a problem hiding this comment.
"sandbox?" isn't a reason. Please find the real one, or move the ignores to a separate PR
| [ .[] | select(.executable != null) | .executable | select(test("/coreutils$") | not) ] | ||
| | unique | ||
| | .[] | ||
| ' | sed 's#^.*$#adb push & /data/local/tmp/tester\nadb shell "cd /data/local/tmp \&\& UUTESTS_BINARY_PATH=/data/local/tmp/coreutils /data/local/tmp/tester"#' > tests.sh |
There was a problem hiding this comment.
generating shell with sed is hard to read. Could tests.sh be a simple loop over the list?
There was a problem hiding this comment.
No. script: section rejected any loop syntax.
6c90098 to
7f948fa
Compare
|
Binary size comparison: |
193a835 to
b769eb0
Compare
|
I updated ignored comment, or adjusted tests except for |
b769eb0 to
d120c1c
Compare
Merging this PR will degrade performance by 3.02%1 warning, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
|
GNU testsuite comparison: |
Closes #16669 Closes #16619 Closes #16663