Repository navigation
pr: fill the rest of a merged page with empty lines - #16717
Open
ihsandeniz wants to merge 1 commit into
Open
ihsandeniz wants to merge 1 commit into
ihsandeniz wants to merge 1 commit into
Conversation
Like GNU pr, once every file has run out, the rest of the page is empty lines rather than padded empty columns.
sylvestre
reviewed
Nov 19, 2026
| @@ -1599,8 +1599,13 @@ fn write_columns( | |||
| for row in table { | |||
| // Merged files are padded with empty cells to fill the page; once | |||
| // every file has run out there is nothing left to print. | |||
Contributor
There was a problem hiding this comment.
this comment is now half wrong, "nothing left to print" is only true without a trailer. could you merge it with the one below?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #16555, as asked there.
With
-mand a page trailer, once every file has run out the rest of the page was printed as padded empty columns: each line got the column width in spaces and a TAB. GNU writes plain empty lines there.The blank lines in
test_mergeare updated to match.I wrote this with the help of an AI assistant; the expected output comes from running GNU's
prbinary.