Repository navigation
pr: take the full length of a -S separator from the page width - #16719
Open
ihsandeniz wants to merge 1 commit into
Open
ihsandeniz wants to merge 1 commit into
ihsandeniz wants to merge 1 commit into
Conversation
Like GNU pr, each byte of the separator takes one column, so -Sdivide with two columns leaves (W - 6) / 2 columns of text instead of (W - 1) / 2. The fixture of -Sdivide is regenerated, as its columns are narrower now.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #16555, as asked there.
The column width took one column per separator whatever its length. GNU counts every byte of a
-Sstring, so with-Sdivideand two columns each column is(W - 6) / 2wide, not(W - 1) / 2.The
-Sdividefixture is regenerated from GNU, as its columns are narrower now, and a test covers-Sdivideand-S::.I wrote this with the help of an AI assistant; the expected output comes from running GNU's
prbinary.