Repository navigation
chown, chgrp: format +ID specs and group-only changes on broken symlinks - #16720
Open
yunusarda-sudo wants to merge 1 commit into
Open
yunusarda-sudo wants to merge 1 commit into
yunusarda-sudo wants to merge 1 commit into
Conversation
Strip leading '+' from numeric user/group IDs in verbose diagnostics when dereferencing a broken symlink fails, and describe group-only modifications as group changes, matching GNU coreutils. Fixes uutils#16500
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16500
Description
When running
chown -vorchgrp -von a broken symlink,ChownExecutor::traversereported the failure usingself.raw_ownerdirectly and always described it as failing to change "ownership".This caused two discrepancies with GNU coreutils:
+UIDor:+GIDwas passed, the leading+was echoed verbatim in the error message (e.g.failed to change ownership of ... to +1000:+1000).groups_onlywas set as inchgrp), it printed "failed to change ownership ..." instead of "failed to change group ...".Changes
target_spec(&self) -> (&'static str, String)inChownExecutor(src/uucore/src/lib/features/perms.rs) to:+from user and group IDs."group"instead of"ownership"when only group is changed orverbosity.groups_onlyis true.test_chown_verbose_broken_symlink_plus_idsintests/by-util/test_chown.rs.