-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ptx: handle duplicate input files #9823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDryden
reviewed
Dec 24, 2025
|
GNU testsuite comparison: |
Contributor
|
sorry, it needs to be rebased, thanks |
645ec78 to
3308729
Compare
ChrisDryden
reviewed
Jan 7, 2026
|
GNU testsuite comparison: |
Collaborator
|
Rebasing to show tracking that the ptx gnu integ test will be passing now after this pr, kudos! |
|
GNU testsuite comparison: |
Contributor
well done :) |
mattsu2020
pushed a commit
to mattsu2020/coreutils
that referenced
this pull request
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Running
ptx file filewould only output the content of thefileonce. This caused the GNU testptx ws.in ws.in | sort | uniq -uto fail (it expects identical output twice, whichuniq -ufilters out; we were outputting once, souniq -uprinted it).Input files were stored in a
HashMapkeyed by filename. The second occurrence of the file overwrote the first.Fix
Changed the internal
FileMapstorage to aVecto preserve the order and multiplicity of input files.Tests
tests/ptx/ptx-overrun.share now passing correctly.test_duplicate_input_filesintests/by-util/test_ptx.rs.