Skip to content

refactor: expose trigger outputs as static Action.Input fields (#24454) (CP: 25.2)#24482

Merged
tltv merged 1 commit into
25.2from
cherry-pick-24454-to-25.2-1780078517137
Jun 1, 2026
Merged

refactor: expose trigger outputs as static Action.Input fields (#24454) (CP: 25.2)#24482
tltv merged 1 commit into
25.2from
cherry-pick-24454-to-25.2-1780078517137

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #24454 to branch 25.2.

Original PR description

ClickTrigger's per-instance accessors are replaced by static fields on a new MouseEventTrigger superclass; DoubleClickTrigger is added as a sibling. HandlerInput is now scoped by trigger class instead of instance, letting one Action.Input be shared across every instance of the owning class and its subclasses while still being rejected in unrelated trigger families. MouseEventTrigger.Output is left extensible (non-final, protected constructor) so subclasses can add event-specific fields when needed.

Related to #24449

ClickTrigger's per-instance accessors are replaced by static fields on a
new MouseEventTrigger superclass; DoubleClickTrigger is added as a
sibling. HandlerInput is now scoped by trigger class instead of
instance, letting one Action.Input be shared across every instance of
the owning class and its subclasses while still being rejected in
unrelated trigger families. MouseEventTrigger.Output is left extensible
(non-final, protected constructor) so subclasses can add event-specific
fields when needed.

Related to #24449
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Test Results

 1 430 files  +1   1 430 suites  +1   1h 25m 23s ⏱️ + 3m 28s
10 047 tests +2   9 979 ✅ +2  68 💤 ±0  0 ❌ ±0 
10 519 runs  +2  10 450 ✅ +2  69 💤 ±0  0 ❌ ±0 

Results for commit 525b3dc. ± Comparison against base commit 51c83e4.

@tltv tltv merged commit f15f85a into 25.2 Jun 1, 2026
33 checks passed
@tltv tltv deleted the cherry-pick-24454-to-25.2-1780078517137 branch June 1, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants