工程化加固、安全与性能修复、API 契约统一 snake_case（含 CI 测试流水线） - #514
Open
Marrrrrrrrry wants to merge 36 commits into
Open
Conversation
…cleanup - add pyproject.toml with pytest config and dev dependency group (PEP 735) - add ruff (core correctness rules) + pre-commit hook - fix stored XSS: html.escape site config before index template injection, with regression tests - log previously swallowed cleanup exceptions in upload rollback paths - consolidate three duplicate path generators into build_file_path (also aligns chunk/presign date dirs to get_now() instead of local time) - drop redundant ip_limit sync in load_config (refresh_settings covers all limiters) - remove dead code (calculate_file_hash, commented-out block), two orphan guide docs, and stale .gitignore entries - add dependabot for pip, docker, and github-actions - bump starlette 1.3.1 -> 1.6.0 (no breaking API changes; verified with the full test suite plus an ASGI smoke test incl. Range downloads) - skip theme asset tests when themes/ is not built locally
|
@Marrrrrrrrry is attempting to deploy a commit to the vastsa's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
我要加入vercel组吗？然后问下最近的迭代计划 我不太喜欢处理分支冲突（我知道ai能做但是怕我们在相同开发位置撞车） 如果你最近有开发计划我就等等再修复/做新功能和pr |
- tests/helpers.py: SettingsOverrideMixin + init_memory_db()/close_db() - tests/conftest.py: httpx ASGI client fixtures (db, client, initialized_client) - enable pytest asyncio_mode=auto - replace 6 duplicated SettingsOverrideMixin copies and 4 duplicated Tortoise.init blocks across the legacy unittest suite
…le chunks, presign sessions)
…, cancel, size limit)
…akout in 2023 theme
… rehash - new hashes use scrypt (n=2^14, r=8, p=1); sha256 and plaintext formats keep verifying unchanged, so existing deployments are unaffected - on successful login a legacy-stored admin password is rehashed to scrypt in the settings KeyValue row - add password_needs_rehash() and extend scheme detection; stdlib only, no new dependency
…hared rollback helper
…o storage base class
…no longer imports apps)
…hed chunk records (core/ is now ORM-free)
…tically by app handler
…148 lines) - apps/base/setup_wizard.py: form parsing rules, setup options, and the two admin-facing HTML pages - apps/base/pages.py: setup/assets/index/robots/public-config routes and theme resolution (404 handler registered on the app in main.py) - tests updated to import from the new modules
…) and add config schema guard - opendal_scheme was read directly by the OpenDAL backend but never declared in DEFAULT_CONFIG: selecting that backend crashed with AttributeError - chunk_expire_hours existed only as getattr fallbacks in two modules - refresh_settings now warns about unknown user_config keys - meta-test scans the codebase so any future settings.X reference without a DEFAULT_CONFIG declaration fails the suite
- 20 camelCase keys (uploadSize, expireStyle, openUpload, ...) renamed across DEFAULT_CONFIG, settings accessors, setup form fields, and ConfigService - migrations_007 renames keys inside the existing settings KeyValue row, preserving all values for existing deployments - schema guard meta-test keeps future keys declared
…share (D2) - storage contract drops UploadFile in favor of BinaryIO (+content_type param), completing the framework decoupling of the storage layer - LocalFileClass.read() leaked an open fd and its handle was passed where save_file expected UploadFile — /admin/local/share 500ed on every call; now reads bytes via with-block and shares correctly (regression tests added) - OneDrive save_file additionally had save_path called as a function — fixed
- quota.get_storage_usage (runs on every upload) now aggregates via Sum instead of loading every row - dashboard simple counters (total/size/expired/active/text/chunked/used, yesterday/today, top suffixes, recent 8) moved to SQL; the per-row health rules engine keeps its single pass (documented)
…nstantly-expired 0 (D4)
…ess lock (D5) settings/activities/view-presets are whole-blob KeyValue rows; concurrent admin operations could silently drop each other's writes (last-writer-wins). Single-worker deployment assumption documented; lock is process-local.
…e (2.3) share_text/share_file/complete_upload/presign proxy/presign confirm now delegate quota reservation, storage writes, record creation, rollback and chunk cleanup to service methods; handlers keep auth, request validation, rate limiting and response wrapping. validate_file_size and PRESIGN_SESSION_EXPIRES move to services as shared single sources.
Drop the message/msg envelope twin, all camel+snake dual-field response pairs (file list/detail/policy/storage, dashboard counters, batch op counts, status insights, presets, metadata), and camel request fields (clearExpiredAt, downloadLimit, sortBy/sortOrder, maxChars). Stored KeyValue JSON (metadata, presets, activities) keeps legacy-key read fallbacks so existing deployments normalize transparently.
…sign page API version 2.1.0 -> 2.5.6; response examples use the single message field; dashboard/list examples and params match current snake_case contract; drop stale save_path from presign init response; add English presign-upload page and sidebar entry; uploadSize -> upload_size.
Sync zh/en guide docs with migration 007 key names (upload_size, open_upload, enable_chunk, expire_style, error_count, etc.) so existing deployments following the docs use the current schema.
build_public_config/build_public_meta served a mixed camel/snake contract (allowedFileTypes, meta.features.*, api.legacyConfig, limits.uploadWindowMinutes). Rename to snake_case; frontend reads allowed_file_types only.
- ci.yml: ruff + pytest on push/PR, installing from the hashed lockfile with --require-hashes, plus a lockfile-vs-requirements consistency check (dependabot cannot regenerate the lockfile; drift was silent). - test_api_contract.py: deep-scans public config, dashboard, admin file list and share metadata responses for camelCase keys - the regression net for the D7 public-config leak found during review.
Marrrrrrrrry
changed the title
Author
概述本 PR 包含 36 个提交，覆盖：工程化基建补齐、安全加固、性能修复、架构重构与 API 契约统一。 合入前置条件（请务必阅读）
变更清单工程化基建
安全修复
性能修复
功能修复
架构重构
API 契约统一（向前不兼容）
测试验证
已知边界
|
Author
|
本地我做了e2e docker构建 冒烟 但是没做现有用户升级测试 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cleanup