fix(metrics): add _total suffix to memory enrichment counters#25496
Open
AkshantVats wants to merge 1 commit into
Open
fix(metrics): add _total suffix to memory enrichment counters#25496AkshantVats wants to merge 1 commit into
AkshantVats wants to merge 1 commit into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Rename three memory enrichment table counters to comply with the instrumentation spec (counters must end with _total). Fixes vectordotdev#25455 Co-authored-by: Cursor <cursoragent@cursor.com>
AkshantVats
force-pushed
the
fix/memory-enrichment-counters-total-suffix
branch
from
3133039 to
6370506
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames three memory enrichment table counter metrics to end with
_total, per instrumentation spec ("Counters MUST end withtotal").Fixes #25455
memory_enrichment_table_failed_insertionsmemory_enrichment_table_failed_insertions_totalmemory_enrichment_table_failed_readsmemory_enrichment_table_failed_reads_totalmemory_enrichment_table_ttl_expirationsmemory_enrichment_table_ttl_expirations_totalBreaking change
Anyone scraping the old metric names will need to update dashboards/alerts. These metrics were introduced with the memory enrichment table feature; happy to add deprecated aliases if maintainers prefer.
Test plan
cargo test -p vector-common