feat(buffers): SUT-side antithesis underflow assertions#25526
Draft
blt wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 29, 2026
0ca18b0 to
694f3cf
Compare
579bdea to
3bb6d14
Compare
|
3bb6d14 to
7ce6082
Compare
02c0a7b to
9cc1ecd
Compare
7ce6082 to
84f01cb
Compare
Adds antithesis_sdk + antithesis-instrumentation deps and three #[inline] assert_always! guards that fold away in production builds (no-ops outside Antithesis) at the unchecked-arithmetic sites: ledger.rs decrement_total_buffer_size and get_total_records (#21683 / 0-1 underflow), and reader.rs:524 data-file size-delta. These guide Antithesis to the accounting-underflow cluster (organically reproduced #21683 in run D0).
9cc1ecd to
86613d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds the
antithesis_sdk+antithesis-instrumentationdependencies tovector-buffersand three#[inline] assert_always!guards at the unchecked-arithmetic sites that drive the #21683 accounting-underflow cluster:
Ledger::decrement_total_buffer_size,Ledger::get_total_records, and thereader.rs:524data-file size-delta. The assertions are no-ops outside theAntithesis environment and
#[inline]so they fold away in production builds.How did you test this PR?
cargo build -p vector-buffers/cargo nextest run -p vector-buffers. UnderAntithesis, the
decrement_total_buffer_sizeguard already fired organically(reproducing #21683).
make build-licensesregenerated the 3rd-party licenseinventory for the new deps.
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References