fix(core): infer s.any() as any instead of unknown in validate return type#254
Open
tmchow wants to merge 1 commit intovercel-labs:mainfrom
Open
fix(core): infer s.any() as any instead of unknown in validate return type#254tmchow wants to merge 1 commit intovercel-labs:mainfrom
tmchow wants to merge 1 commit intovercel-labs:mainfrom
Conversation
… type InferSpecField mapped SchemaType<"any"> to unknown, which made catalog.validate() return types incompatible with Spec. Fields like visible: s.any() produced visible: unknown instead of visible: any, forcing as-casts. Now maps to any, matching Zod's z.any() behavior. Fixes vercel-labs#251
Contributor
|
@tmchow is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InferSpecFieldmappedSchemaType<"any">tounknown, makingcatalog.validate()return types incompatible withSpec. Fields likevisible: s.any()producedvisible: unknowninstead ofvisible: any, forcingas unknown as Speccasts.Changes
packages/core/src/schema.ts: Changed theInferSpecFieldconditional type to mapSchemaType<"any">toanyinstead ofunknown. This matches how Zod'sz.any()infers and makes the validated spec directly assignable toSpec.Testing
All 892 existing tests pass.
pnpm type-checkpasses.Fixes #251
This contribution was developed with AI assistance (Codex).