fix(anthropic): keep tools array when toolChoice is 'none'#12609
Closed
giulio-leone wants to merge 2 commits intovercel:mainfrom
Closed
fix(anthropic): keep tools array when toolChoice is 'none'#12609giulio-leone wants to merge 2 commits intovercel:mainfrom
giulio-leone wants to merge 2 commits intovercel:mainfrom
Conversation
6863fa0 to
744adcd
Compare
744adcd to
91236b1
Compare
Author
|
Intervention note for this PR: Current blocker appears to be Vercel deployment authorization, not code/test correctness. Observed pattern:
Recommended unblock sequence:
If useful, I can follow up with a PR-by-PR status sweep after authorization is completed. |
Author
|
Ready for review — fixes Anthropic provider failing when toolChoice is 'none' by preserving the tools array. Includes regression test. |
Author
|
This PR is ready for review — all CI checks pass, no merge conflicts, and all review threads have been resolved. Ready to merge when approved. 🚀 |
91236b1 to
f81d6a2
Compare
Author
|
Hi! Gentle ping — this PR is rebased on main, CI passes, and ready for review. Happy to address any feedback. Thanks! |
Author
|
Closing to reduce PR volume. Happy to resubmit if useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12378
Problem
When toolChoice is 'none', the Anthropic provider strips both tools and tool_choice from the API request. This causes empty content response when conversation history contains tool_use/tool_result blocks.
Fix