feat: support callable values for credentials config#32
Merged
Conversation
Allows Proc/Lambda for deferred evaluation, enabling use with Rails.application.credentials which isn't available at initializer load time. Fully backward compatible with static string values. Closes #31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usernameandpasswordconfiguration, enabling use withRails.application.credentialsand other deferred sourcesCloses #31
Changes
lib/solid_queue_monitor.rb— Custom reader methods that resolve callable values viarespond_to?(:call)lib/generators/.../initializer.rb— Added ENV and Lambda examples in commentsREADME.md— Authentication section now shows all three credential approachesCHANGELOG.md— Added v1.2.1 entryversion.rb— Bumped to 1.2.1Test plan
Rails.application.credentialsin demo app