fix(ci): add fail-fast false and allow macOS clean-false to fail#69
Merged
Conversation
Two issues fixed: 1. Add `fail-fast: false` to prevent a single matrix job failure from cancelling all other in-flight scenarios. 2. Add `continue-on-error: true` for `macos-latest + clean-false`: building V from source on macOS ARM64 fails because the bootstrap compiler does not understand `$if !native`. This is a pre-existing upstream V bootstrap issue, not a regression in this action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CI matrix uses default
fail-fast: true, so whentest-action (macos-latest, clean-false)fails, all 20 other in-flight jobs are cancelled. This makes the CI red even when only one known edge case fails.The
macos-latest + clean-falsescenario fails because building V from source on macOS ARM64 hits an upstream bootstrap issue: thevccompiler does not understand$if !native.Fix
fail-fast: falseto the matrix strategy — each scenario runs independently.continue-on-error: trueformacos-latest + clean-false— this is a pre-existing upstream V bootstrap issue, not a regression in this action.