[Model] Add T5Gemma2 model plugin integration#8
Open
akh64bit wants to merge 10 commits intovllm-project:masterfrom
Open
[Model] Add T5Gemma2 model plugin integration#8akh64bit wants to merge 10 commits intovllm-project:masterfrom
akh64bit wants to merge 10 commits intovllm-project:masterfrom
Conversation
Signed-off-by: Akhilesh Kumar <akhilbussiness@gmail.com>
Signed-off-by: Akhilesh Kumar <akhilbussiness@gmail.com>
Author
|
I've added an |
Signed-off-by: Akhilesh Kumar <akhilbussiness@gmail.com>
Signed-off-by: Akhilesh Kumar <akhilbussiness@gmail.com>
Signed-off-by: Akhilesh Kumar <akhilbussiness@gmail.com>
Signed-off-by: Akhilesh Kumar <akhilbussiness@gmail.com>
Signed-off-by: Akhilesh Kumar <akhilbussiness@gmail.com>
Signed-off-by: Akhilesh Kumar <akhilbussiness@gmail.com>
Signed-off-by: Akhilesh Kumar <akhilbussiness@gmail.com>
Signed-off-by: Akhilesh Kumar <akhilbussiness@gmail.com>
|
Awesome! I've been looking for a good way to experiment with T5gemma2. How do you find its performance in comparison with other models of similar size? Are there any issues/limitations/things to be aware of when using it with vLLM? |
NickLucche
reviewed
Mar 17, 2026
Collaborator
NickLucche
left a comment
There was a problem hiding this comment.
Thanks for contributing @akh64bit !
Will look to get this merged after v0.16 support, as I see some of the changes are related to moving imports around (to sync with upstream)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
T5Gemma2encoder-decoder model as an out-of-tree vLLM plugin, moving the implementation from the corevllmrepository as suggested in vllm-project/vllm#32617.Changes
vllm_bart_plugin/t5gemma2.py.q,k, andvtensor reshaping bugs in attention inputs (MMEncoderAttentionand vLLM'sAttentionexpect(num_tokens, num_heads, head_dim), not(1, num_tokens, hidden_size)).T5Gemma2DecoderLayerblock.rotary_emb) is correctly applied during the forward pass.SupportsMultiModalinterface mapping.Attentionimports to work with the latest vLLM versions.vllm_bart_plugin/__init__.py.How to test locally
To run this plugin alongside vLLM, ensure you have the required specific
transformersfork and vLLM installed, then install the plugin in editable mode: