Skip to content

fix(tools): fail on Vite branding source drift#2205

Merged
wan9chi merged 4 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/harden-brand-vite-patcher
Jul 20, 2026
Merged

fix(tools): fail on Vite branding source drift#2205
wan9chi merged 4 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/harden-brand-vite-patcher

Conversation

@liangmiQwQ

@liangmiQwQ liangmiQwQ commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

The Vite branding patcher currently treats a missing removable build-banner pattern as "Already patched". When upstream changes, sync can continue even though the branding patch no longer applies.

This PR restores the nested Vite checkout from HEAD before each patch pass, so repeated calls still start from raw upstream sources. If a restored source no longer matches a known pattern, the patcher raises an actionable upstream-drift error instead.

It leaves the build-banner behavior and CLI snapshots unchanged.

A small follow-up to #2200

🤖 Generated with Codex

@netlify

netlify Bot commented Jul 20, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 72e5a80
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a5daf9aea4b6e0008d148e0

@liangmiQwQ
liangmiQwQ force-pushed the liang/codex/harden-brand-vite-patcher branch from 7178aac to d78a8d0 Compare July 20, 2026 03:48
@liangmiQwQ
liangmiQwQ marked this pull request as ready for review July 20, 2026 03:56
@liangmiQwQ
liangmiQwQ requested a review from wan9chi July 20, 2026 03:58
@liangmiQwQ

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d78a8d02f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/tools/src/brand-vite.ts
@liangmiQwQ
liangmiQwQ marked this pull request as draft July 20, 2026 04:20
@liangmiQwQ
liangmiQwQ marked this pull request as ready for review July 20, 2026 04:33
@liangmiQwQ

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 618f894f16

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@wan9chi
wan9chi merged commit 04692be into voidzero-dev:main Jul 20, 2026
42 checks passed
@liangmiQwQ
liangmiQwQ deleted the liang/codex/harden-brand-vite-patcher branch July 20, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants