fix(workspace): ignore packages inside node_modules#539
Open
jong-kyung wants to merge 2 commits into
Open
Conversation
jong-kyung
force-pushed
the
fix/ignore-node-modules-workspaces
branch
2 times, most recently
from
07fc7cf to
f8c7e01
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e76cbf61bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: GPT-5.2 <codex@openai.com>
jong-kyung
force-pushed
the
fix/ignore-node-modules-workspaces
branch
from
f8c7e01 to
667d805
Compare
Signed-off-by: JongKyung Lee <jongkyung0413@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Broad workspace patterns such as
samples/**causedvp runto treat installed dependencies beneathnode_modulesas workspace packages and execute their matching scripts. Workspace discovery now prunes everynode_modulestree before package manifests are collected, while preserving legitimate nested workspace packages.A regression test covers the reported broad-glob layout and verifies that only the root and intended app package are discovered.
Related: voidzero-dev/vite-plus#2153